Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario #612

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

JohnTParsons
Copy link
Collaborator

@JohnTParsons JohnTParsons commented Feb 7, 2023

PPDSC-2779

What

Paragraph now aligned by default

Storybook 2023-02-07 at 11 47 21

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

https://nidigitalsolutions.jira.com/wiki/spaces/NPP/pages/edit-v2/4294869034 includes a description of the change.

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@JohnTParsons JohnTParsons requested a review from a team as a code owner February 7, 2023 12:05
@github-actions github-actions bot added the fix This change fixes a bug label Feb 7, 2023
@pp-serviceaccount
Copy link
Collaborator

@JohnTParsons JohnTParsons added the ready for review Please assist in getting this reviewed label Feb 7, 2023
@JohnTParsons JohnTParsons merged commit 3a7aa01 into v7-breaking-changes Feb 8, 2023
@JohnTParsons JohnTParsons deleted the fix/PPDSC-2779-ordered-list-para branch February 8, 2023 09:16
mstuartf added a commit that referenced this pull request Feb 28, 2023
* chore(PPDSC-2412): major version 7.0.1

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* feat(PPDSC-2782): changing dividerInverse color (#613)

* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap

* chore(PPDSC-2775): update accordion default styles (#602)

* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>

* fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>

* chore(PPDSC-2723): update Slider component defaults (#606)

* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme

* chore(PPDSC-2776): update Link component defaults (#614)

* chore(PPDSC-2776): link updates

* chore(PPDSC-2776): lint fix

* feat(PPDSC-2726): update snap (#615)

* chore(PPDSC-2774): update Popover component defaults (#617)

* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots

* chore(PPDSC-2722): update Select component defaults (#608)

* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo

* chore(PPDSC-2725): banner (#607)

* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes

* Chore/ppdsc 2778 tag default styles (#622)

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child

* feat(PPDSC-2781): update menu defaults (#616)

* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

* feat(PPDSC-1940): remove Link component (#624)

* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>

* feat(PPDSC2091): caption refactoring (#627)

* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs

* feat(PPDSC-2422): update newskit light and dark theme tokens (#632)

* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots

* feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641)

* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots

* chore(PPDSC-1866): remove crop config (#625)

* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments

* feat(PPDSC-2817): replace space inset (#642)

* feat(PPDCS-2817): banner, block, card, flag, button, iconButton

* feat(PPDCS-2817): menu fieldset and gridlayout

* feat(PPDCS-2817): select

* feat(PPDCS-2817): strucutured list

* feat(PPDCS-2817): text-field

* feat(PPDCS-2817): tabs

* feat(PPDCS-2817): toast, video-player

* feat(PPDCS-2817): tag, toast and dialog

* fix(PPDCS-2817): update docs token

* feat(PPDCS-2817): codemod & tests

* fix(PPDCS-2817): run codemod on site

* fix(PPDCS-2817): update docs types and codemod

* fix(PPDCS-2817): update snapshots

* feat(PPDCS-2817): split into start and end in defaults

* fix(PPDCS-2817): lint

* fix(PPDCS-2817): remove test.only

* fix(PPDCS-2817): sidebar

* feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults"

This reverts commit d2b4541.

* fix(PPDCS-2817): change logical props order

* fix(PPDCS-2817): update docs

* fix(PPDCS-2817): test

* fix(PPDCS-2817): update more docs

* fix(PPDCS-2817): address reviews

* fix(PPDCS-2817): update snapshots

* fix(PPDCS-2817): codemod when stylePreset is added to Block

* fix(PPDCS-2817): add logical props to accordion

* fix(PPDCS-2817): update name

* fix(PPDCS-2817): remove logical props from accordion group

* chore(PPDSC-0000): typo

* chore(PPDSC-0000): snapshot fix

* fix(PPDSC-0000): update tests

---------

Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk>
Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk>
Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com>
Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>
mutebg added a commit that referenced this pull request Mar 1, 2023
* chore(PPDSC-2412): major version 7.0.1

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* feat(PPDSC-2782): changing dividerInverse color (#613)

* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap

* chore(PPDSC-2775): update accordion default styles (#602)

* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>

* fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>

* chore(PPDSC-2723): update Slider component defaults (#606)

* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme

* chore(PPDSC-2776): update Link component defaults (#614)

* chore(PPDSC-2776): link updates

* chore(PPDSC-2776): lint fix

* feat(PPDSC-2726): update snap (#615)

* chore(PPDSC-2774): update Popover component defaults (#617)

* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots

* chore(PPDSC-2722): update Select component defaults (#608)

* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo

* chore(PPDSC-2725): banner (#607)

* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes

* Chore/ppdsc 2778 tag default styles (#622)

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child

* feat(PPDSC-2781): update menu defaults (#616)

* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

* feat(PPDSC-1940): remove Link component (#624)

* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>

* feat(PPDSC2091): caption refactoring (#627)

* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs

* feat(PPDSC-2798): add css variables

* feat(PPDSC-2798): add files

* feat(PPDSC-2798): add fonts

* feat(PPDSC-2798): update site snapshots

* feat(PPDSC-2422): update newskit light and dark theme tokens (#632)

* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots

* feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641)

* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots

* feat(PPDSC-2798): update docs

* chore(PPDSC-1866): remove crop config (#625)

* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments

* feat(PPDSC-2798): fix coverage

* feat(PPDSC-2798): fixing tests

* feat(PPDSC-2798): fix tests

* feat(PPDSC-2798): rename-var

* feat(PPDSC-2798): update tests

---------

Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: mstuartf <mstuartflood@gmail.com>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk>
Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
JohnTParsons added a commit that referenced this pull request Mar 7, 2023
* chore(PPDSC-2412): major version 7.0.1

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* feat(PPDSC-2782): changing dividerInverse color (#613)

* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap

* chore(PPDSC-2775): update accordion default styles (#602)

* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>

* fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>

* chore(PPDSC-2723): update Slider component defaults (#606)

* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme

* chore(PPDSC-2776): update Link component defaults (#614)

* chore(PPDSC-2776): link updates

* chore(PPDSC-2776): lint fix

* feat(PPDSC-2726): update snap (#615)

* chore(PPDSC-2774): update Popover component defaults (#617)

* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots

* chore(PPDSC-2722): update Select component defaults (#608)

* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo

* chore(PPDSC-2725): banner (#607)

* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes

* Chore/ppdsc 2778 tag default styles (#622)

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child

* feat(PPDSC-2781): update menu defaults (#616)

* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

* feat(PPDSC-1940): remove Link component (#624)

* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>

* feat(PPDSC2091): caption refactoring (#627)

* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs

* feat(PPDSC-2422): update newskit light and dark theme tokens (#632)

* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots

* feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641)

* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots

* chore(PPDSC-1866): remove crop config (#625)

* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments

* feat(PPDSC-2817): replace space inset (#642)

* feat(PPDCS-2817): banner, block, card, flag, button, iconButton

* feat(PPDCS-2817): menu fieldset and gridlayout

* feat(PPDCS-2817): select

* feat(PPDCS-2817): strucutured list

* feat(PPDCS-2817): text-field

* feat(PPDCS-2817): tabs

* feat(PPDCS-2817): toast, video-player

* feat(PPDCS-2817): tag, toast and dialog

* fix(PPDCS-2817): update docs token

* feat(PPDCS-2817): codemod & tests

* fix(PPDCS-2817): run codemod on site

* fix(PPDCS-2817): update docs types and codemod

* fix(PPDCS-2817): update snapshots

* feat(PPDCS-2817): split into start and end in defaults

* fix(PPDCS-2817): lint

* fix(PPDCS-2817): remove test.only

* fix(PPDCS-2817): sidebar

* feat(PPDCS-2817): Revert "feat(PPDCS-2817): split into start and end in defaults"

This reverts commit d2b4541.

* fix(PPDCS-2817): change logical props order

* fix(PPDCS-2817): update docs

* fix(PPDCS-2817): test

* fix(PPDCS-2817): update more docs

* fix(PPDCS-2817): address reviews

* fix(PPDCS-2817): update snapshots

* fix(PPDCS-2817): codemod when stylePreset is added to Block

* fix(PPDCS-2817): add logical props to accordion

* fix(PPDCS-2817): update name

* fix(PPDCS-2817): remove logical props from accordion group

* chore(PPDSC-0000): typo

* chore(PPDSC-0000): snapshot fix

* fix(PPDSC-0000): update tests

---------

Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk>
Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
Co-authored-by: Stoyan Delev <stoyan.delev@news.co.uk>
Co-authored-by: Stoyan Delev <mutebg@users.noreply.github.com>
Co-authored-by: Michael Flood <michaelflood@Michaels-Mac-mini.local>
JohnTParsons added a commit that referenced this pull request Mar 7, 2023
* chore(PPDSC-2412): major version 7.0.1

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* feat(PPDSC-2782): changing dividerInverse color (#613)

* feat(PPDSC-2782): changing sp

* feat(PPDSC-2782): add new line

* feat(PPDSC-2782): updated snap

* chore(PPDSC-2775): update accordion default styles (#602)

* fix(PPDSC-2775): update icon styles

* fix(PPDSC-2775): design review

* fix(PPDSC-2775): design reviews

* chore(PPDSC-2412): audio player styling changes (#592)

* chore(PPDSC-2412): audio player styling changes

* chore(PPDSC-2412): linting and comments

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): typo

* chore(PPDSC-2412): simplify style presets

* chore(PPDSC-2412): revert typo

* chore(PPDSC-2412): update snapshots

* chore(PPDSC-2412): add codemod to apply all style changes

* chore(PPDSC-2412): update readme

* chore(PPDSC-2775): codemod for accordion

* fix(PPDSC-2775): revert readme

* fix(PPDSC-2775): lint and snapshots

* fix(PPDSC-2775): update codemods

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): lint

* fix(PPDSC-2775): remove fontColorChange from button

---------

Co-authored-by: mstuartf <mstuartflood@gmail.com>

* fix(PPDSC-2779): Improve handling of OrderedList paragraph scenario (#612)

* fix(PPDSC-2779): improve handling of OrderedList paragraph scenario

---------

Co-authored-by: JohnTParsons <JohnTParsons>

* chore(PPDSC-2723): update Slider component defaults (#606)

* chore(PPDSC-2723): update Slider component defaults

* chore(PPDSC-2723): remove codemod

* chore(PPDSC-2723): update snapshots

* chore(PPDSC-2723): remove line from readme

* chore(PPDSC-2776): update Link component defaults (#614)

* chore(PPDSC-2776): link updates

* chore(PPDSC-2776): lint fix

* feat(PPDSC-2726): update snap (#615)

* chore(PPDSC-2774): update Popover component defaults (#617)

* chore(PPDSC-2774): update Popover component defaults

* chore(PPDSC-2774): update snapshots

* chore(PPDSC-2722): update Select component defaults (#608)

* chore(PPDSC-2722): update Select component defaults

* chore(PPDSC-2722): update snapshots

* chore(PPDSC-2722): remove codemod code

* chore(PPDSC-2722): addProp util to support filtering by custom prop

* chore(PPDSC-2722): fix typo

* chore(PPDSC-2725): banner (#607)

* chore(PPDSC-2725): banner default styling changes

* chore(PPDSC-2725): vertical spacing

* chore(PPDSC-2725): story update

* chore(PPDSC-2725): snapshots

* chore(PPDSC-2725): storybook styling

* chore(PPDSC-2725): revert space inset changes

* Chore/ppdsc 2778 tag default styles (#622)

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests

* chore(PPDSC-2778): updatedt tests-stack child

* feat(PPDSC-2781): update menu defaults (#616)

* feat(PPDSC-2781): update menu defaults

* fix(PPDSC-2781): update menu

* fix(PPDSC-2781): update docs

* fix(PPDSC-2781): remove extra border-box

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults (#605)

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults fixed defaults

* chore(PPDSC-2780): chore/ppdse-2780-titlebar-defaults-add logicap props

* chore(PPDSC-2780): chore/ppdse-2780-added logical props

* chore(PPDSC-2780): updatedt tests

* chore(PPDSC-2780): updatedt tests-theme

* chore(PPDSC-2780): updatedt tests-accsessbility

* chore(PPDSC-2780): updatedt tests-site

* chore(PPDSC-2780): updatedt tests for logical props

* chore(PPDSC-2780): updatedt tests for LP

* chore(PPDSC-2780): chore/ppdse-2780-updated types

* chore(PPDSC-2780): chore/ppdse-2780-updated stories

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-tidied

* chore(PPDSC-2780): chore/ppdse-2780-updated snap

* chore(PPDSC-2780): chore/ppdse-2780-updated snapsshots

* chore(PPDSC-2780): chore/ppdse-2780-fixed

* chore(PPDSC-2780): chore/ppdse-2780-updated tests fixed merge

* chore(PPDSC-2780): chore/ppdse-2780-section intro update

* chore(PPDSC-2780): chore/ppdse-2780-updated select

* chore(PPDSC-2780): chore/ppdse-2780-updated documentatyion

* feat(PPDSC-1940): remove Link component (#624)

* feat(PPDSC-1940): remove Link component

* feat(PPDSC-1940): fix tests

* feat(PPDSC-1940): updated gitignore

---------

Co-authored-by: Vanals <marco91vanali@gmail.com>

* feat(PPDSC2091): caption refactoring (#627)

* feat(PPDSC-2091): remove caption-inset  and refactor caption

* feat(PPDSC-2091): add codemod for caption

* feat(PPDSC-2091): add codemod

* feat(PPDSC-2091): finish codemod

* feat(PPDSC-2091): add correct spacing

* feat(PPDSC-2091): update docs

* feat(PPDSC-2091): formating

* feat(PPDSC-2091): made generic space-inset replace fn

* feat(PPDSC-2091): fix lint

* feat(PPDSC-2091): rename file

* feat(PPDSC-2091): fix tests

* feat(PPDSC-2091): address comments

* feat(PPDSC-2091): update default credit style-preset

* feat(PPDSC-2091): update docs

* feat(PPDSC-2798): add css variables

* feat(PPDSC-2798): add files

* feat(PPDSC-2798): add fonts

* feat(PPDSC-2798): update site snapshots

* feat(PPDSC-2422): update newskit light and dark theme tokens (#632)

* feat(PPDSC-2422): update newskit light and dark theme tokens

* feat(PPDSC-2422): update snapshots

* feat(PPDSC-2428): Popover Tooltip AudioPlayer override name (#641)

* feat(PPDSC-2428): popover tooltip audio player override name

* feat(PPDSC-2428): update snapshots

* feat(PPDSC-2798): update docs

* chore(PPDSC-1866): remove crop config (#625)

* chore(PPDSC-1866): remove crop config

* chore(PPDSC-1866): switch to font metrics

* chore(PPDSC-1866): fix coverage

* chore(PPDSC-1866): snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): update snapshots

* chore(PPDSC-1866): remove old comments

* feat(PPDSC-2798): fix coverage

* feat(PPDSC-2798): fixing tests

* feat(PPDSC-2798): fix tests

* feat(PPDSC-2798): rename-var

* feat(PPDSC-2798): update tests

---------

Co-authored-by: JohnTParsons <JohnTParsons>
Co-authored-by: mstuartf <mstuartflood@gmail.com>
Co-authored-by: Marco Vanali <Marco91Vanali@gmail.com>
Co-authored-by: Xin Wang <wangxin00163@yahoo.co.uk>
Co-authored-by: JohnTParsons <JohnTParsons@users.noreply.github.com>
Co-authored-by: Evgeni Nikolov <evgeni.nikolov@news.co.uk>
Co-authored-by: baburay23 <54642337+baburay23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This change fixes a bug ready for review Please assist in getting this reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants