Fix: Slice specific updates (#1917)

newsuk · May 7, 2019 · d684e8e · d684e8e
1 parent f03ec91
commit d684e8e
Show file tree

Hide file tree

Showing 28 changed files with 1,333 additions and 642 deletions.
diff --git a/packages/edition-slices/__tests__/android/__snapshots__/slices-with-style.test.js.snap b/packages/edition-slices/__tests__/android/__snapshots__/slices-with-style.test.js.snap
@@ -281,7 +281,6 @@ exports[`2. leaders 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -363,7 +362,6 @@ exports[`2. leaders 2`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -1008,7 +1006,6 @@ exports[`14. leaders 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }

diff --git a/...ages/edition-slices/__tests__/android/__snapshots__/tablet-slices-with-style.test.js.snap b/...ages/edition-slices/__tests__/android/__snapshots__/tablet-slices-with-style.test.js.snap
@@ -303,7 +303,6 @@ exports[`6. leaders slice - medium 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -1445,7 +1444,6 @@ exports[`21. leaders slice - wide 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -2645,7 +2643,6 @@ exports[`36. leaders slice - huge 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }

diff --git a/packages/edition-slices/__tests__/android/__snapshots__/tiles-with-style.test.js.snap b/packages/edition-slices/__tests__/android/__snapshots__/tiles-with-style.test.js.snap
@@ -223,16 +223,17 @@ exports[`4. tile d 1`] = `
   <Image
     style={
       Object {
-        "width": "45%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   />
   <View
     style={
       Object {
         "paddingBottom": 5,
-        "paddingHorizontal": 10,
-        "width": "55%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   >
@@ -302,16 +303,17 @@ exports[`5. tile e 1`] = `
   <Image
     style={
       Object {
-        "width": "45%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   />
   <View
     style={
       Object {
         "paddingBottom": 5,
-        "paddingHorizontal": 10,
-        "width": "55%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   >
@@ -1004,6 +1006,7 @@ exports[`13. tile m 1`] = `
           "fontSize": 14,
           "lineHeight": 20,
           "paddingBottom": 10,
+          "paddingHorizontal": 40,
           "textAlign": "center",
         }
       }
@@ -1235,7 +1238,6 @@ exports[`16. tile p 1`] = `
           "lineHeight": 35,
           "marginBottom": 5,
           "paddingHorizontal": 10,
-          "paddingTop": 10,
           "textAlign": "center",
         }
       }
@@ -1412,7 +1414,7 @@ exports[`19. tile s 1`] = `
     style={
       Object {
         "color": "#696969",
-        "fontFamily": "TimesDigitalW04",
+        "fontFamily": "TimesDigitalW04-Regular",
         "fontSize": 14,
         "lineHeight": 20,
       }
@@ -2445,16 +2447,18 @@ exports[`32. tile ak 1`] = `
     Object {
       "backgroundColor": "#F0F0F0",
       "flex": 1,
+      "height": 150,
       "marginHorizontal": 5,
+      "overflow": "hidden",
     }
   }
 >
   <View
     style={
       Object {
-        "paddingHorizontal": 15,
-        "paddingTop": 15,
-        "width": "85%",
+        "height": 80,
+        "paddingHorizontal": 10,
+        "paddingTop": 10,
       }
     }
   >
@@ -2463,9 +2467,9 @@ exports[`32. tile ak 1`] = `
         Object {
           "color": "#333333",
           "fontFamily": "TimesModern-Bold",
-          "fontSize": 25,
+          "fontSize": 22,
           "fontWeight": "400",
-          "lineHeight": 27,
+          "lineHeight": 22,
           "marginBottom": 5,
         }
       }
@@ -2477,6 +2481,7 @@ exports[`32. tile ak 1`] = `
     style={
       Object {
         "alignSelf": "flex-end",
+        "marginTop": -25,
         "width": "85%",
       }
     }

diff --git a/packages/edition-slices/__tests__/android/__snapshots__/tiles.test.js.snap b/packages/edition-slices/__tests__/android/__snapshots__/tiles.test.js.snap
@@ -668,7 +668,8 @@ exports[`16. tile p 1`] = `
   linkStyle={
     Object {
       "alignItems": "center",
-      "paddingVertical": 20,
+      "paddingBottom": 10,
+      "paddingTop": 20,
     }
   }
   url="/article/123"

diff --git a/packages/edition-slices/__tests__/ios/__snapshots__/slices-with-style.test.js.snap b/packages/edition-slices/__tests__/ios/__snapshots__/slices-with-style.test.js.snap
@@ -281,7 +281,6 @@ exports[`2. leaders 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -363,7 +362,6 @@ exports[`2. leaders 2`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -1008,7 +1006,6 @@ exports[`14. leaders 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }

diff --git a/packages/edition-slices/__tests__/ios/__snapshots__/tablet-slices-with-style.test.js.snap b/packages/edition-slices/__tests__/ios/__snapshots__/tablet-slices-with-style.test.js.snap
@@ -303,7 +303,6 @@ exports[`6. leaders slice - medium 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -1445,7 +1444,6 @@ exports[`21. leaders slice - wide 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }
@@ -2645,7 +2643,6 @@ exports[`36. leaders slice - huge 1`] = `
   style={
     Object {
       "backgroundColor": "#F0F0F0",
-      "paddingHorizontal": 40,
       "paddingTop": 20,
     }
   }

diff --git a/packages/edition-slices/__tests__/ios/__snapshots__/tiles-with-style.test.js.snap b/packages/edition-slices/__tests__/ios/__snapshots__/tiles-with-style.test.js.snap
@@ -189,16 +189,17 @@ exports[`4. tile d 1`] = `
   <Image
     style={
       Object {
-        "width": "45%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   />
   <View
     style={
       Object {
         "paddingBottom": 5,
-        "paddingHorizontal": 10,
-        "width": "55%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   >
@@ -251,16 +252,17 @@ exports[`5. tile e 1`] = `
   <Image
     style={
       Object {
-        "width": "45%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   />
   <View
     style={
       Object {
         "paddingBottom": 5,
-        "paddingHorizontal": 10,
-        "width": "55%",
+        "paddingRight": 10,
+        "width": "50%",
       }
     }
   >
@@ -824,6 +826,7 @@ exports[`13. tile m 1`] = `
           "fontSize": 14,
           "lineHeight": 20,
           "paddingBottom": 10,
+          "paddingHorizontal": 40,
           "textAlign": "center",
         }
       }
@@ -1011,7 +1014,6 @@ exports[`16. tile p 1`] = `
           "lineHeight": 35,
           "marginBottom": 5,
           "paddingHorizontal": 10,
-          "paddingTop": 10,
           "textAlign": "center",
         }
       }
@@ -1161,7 +1163,7 @@ exports[`19. tile s 1`] = `
     style={
       Object {
         "color": "#696969",
-        "fontFamily": "TimesDigitalW04",
+        "fontFamily": "TimesDigitalW04-Regular",
         "fontSize": 14,
         "lineHeight": 20,
       }
@@ -2014,16 +2016,18 @@ exports[`32. tile ak 1`] = `
     Object {
       "backgroundColor": "#F0F0F0",
       "flex": 1,
+      "height": 150,
       "marginHorizontal": 5,
+      "overflow": "hidden",
     }
   }
 >
   <View
     style={
       Object {
-        "paddingHorizontal": 15,
-        "paddingTop": 15,
-        "width": "85%",
+        "height": 80,
+        "paddingHorizontal": 10,
+        "paddingTop": 10,
       }
     }
   >
@@ -2032,9 +2036,9 @@ exports[`32. tile ak 1`] = `
         Object {
           "color": "#333333",
           "fontFamily": "TimesModern-Bold",
-          "fontSize": 25,
+          "fontSize": 22,
           "fontWeight": "900",
-          "lineHeight": 25,
+          "lineHeight": 22,
           "marginBottom": 5,
         }
       }
@@ -2046,6 +2050,7 @@ exports[`32. tile ak 1`] = `
     style={
       Object {
         "alignSelf": "flex-end",
+        "marginTop": -25,
         "width": "85%",
       }
     }

diff --git a/packages/edition-slices/__tests__/ios/__snapshots__/tiles.test.js.snap b/packages/edition-slices/__tests__/ios/__snapshots__/tiles.test.js.snap
@@ -612,7 +612,8 @@ exports[`16. tile p 1`] = `
   linkStyle={
     Object {
       "alignItems": "center",
-      "paddingVertical": 20,
+      "paddingBottom": 10,
+      "paddingTop": 20,
     }
   }
   url="/article/123"