Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: test utils hash helper #1110

Merged
merged 8 commits into from Jul 13, 2018
Merged

refactor: test utils hash helper #1110

merged 8 commits into from Jul 13, 2018

Conversation

colincclark
Copy link
Contributor

  • make iterator a non-default export from test utils
  • add hash test helper function for long keys in snapshots
  • rolled out and replaced hashing in icon, pagination and watermark packages

craigbilner
craigbilner reviewed Jul 13, 2018
View reviewed changes
packages/test-utils/package.json Outdated
@@ -50,6 +49,9 @@
"webpack": "4.6.0",
"webpack-cli": "2.1.4"
},
"dependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should test-utils just provide the hashing ability rather than tying it into serialization?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

craigbilner
craigbilner suggested changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@craigbilner craigbilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on reflection replaceLongKeys isn't the best name because it replaces the value?

@colincclark colincclark force-pushed the refactor/test-utils-hash-helper branch from 658be9c to bfddb09 Compare July 13, 2018 12:49
@craigbilner craigbilner merged commit 7dde5a8 into master Jul 13, 2018
@craigbilner craigbilner deleted the refactor/test-utils-hash-helper branch July 13, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbilner craigbilner craigbilner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colincclark @craigbilner