fix: remove ghost article flags view #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
parkjh
commented
May 2, 2019
•
parkjh
commented
- removes a padding on an empty articleflag element as there was an additional view component wrapped outside the flag component in the article-sumamary
parkjh
requested review from
aronshamash,
jmars,
nathggns,
nehasri89,
tuncaulubilge and
ValGeorgiev
as code owners
parkjh
commented
May 2, 2019
| @@ -68,7 +68,7 @@ const ArticleSummary = props => { | |||
| {headline()} | |||
| {strapline()} | |||
| {content()} | |||
| {flags() ? <View style={styles.flagWrapper}>{flags()}</View> : null} | |||
There was a problem hiding this comment.
@aronshamash removes view styling here
parkjh
commented
May 2, 2019
| @@ -12,7 +12,8 @@ const styles = { | |||
| }, | |||
| flags: { | |||
| flexDirection: "row", | |||
| flexWrap: "wrap" | |||
| flexWrap: "wrap", | |||
| marginBottom: spacing(2) | |||
There was a problem hiding this comment.
re added the container styling here in the flag component container
aronshamash
approved these changes
May 3, 2019
This was referenced Sep 23, 2023
This was referenced Nov 24, 2023
This was referenced Apr 8, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.