-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TDP-1716): remove react native from utils #2915
feat(TDP-1716): remove react native from utils #2915
Conversation
…internal reference
"paddingVertical", | ||
"textAlign" | ||
]; | ||
import "jest-styled-components"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed this from the request() as for some very strange reason it was complaining about a missing }
packages/article-main-standard/__tests__/web/__snapshots__/article-with-style.web.test.js.snap
Show resolved
Hide resolved
@@ -13,7 +13,7 @@ const respStylesSelector = selector => ({ responsiveLinkStyles }) => | |||
(responsiveLinkStyles && responsiveLinkStyles[selector]) || ""; | |||
|
|||
const RespLink = styled.a` | |||
text-decoration: ${props => | |||
"text-decoration": ${props => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the "
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, otherwise it failed linting
Removed View, Dimension & PixelRation react-native from utils TDP-1716