fix(TDP-1777): Make analytics article_flag data lower case #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othetgyi
approved these changes
Apr 19, 2022
flashcheeks
requested changes
Apr 19, 2022
| article_flag: getIsLiveOrBreakingFlag(flags) || "no flag", | ||
| article_flag: getIsLiveOrBreakingFlag(flags) | ||
| ? getIsLiveOrBreakingFlag(flags).toLowerCase() | ||
| : "no flag", | ||
| article_template_name: getIsLiveOrBreakingFlag(flags) |
There was a problem hiding this comment.
We are now calling getIsLiveOrBreakingFlag three time in this file. We should put this into a const before the return statement.
const isLiveOrBreaking = getIsLiveOrBreakingFlag(flags);
This was referenced Apr 20, 2022
Open
Open
Open
Open
Open
Open
This was referenced Apr 22, 2022
Open
This was referenced Oct 23, 2023
This was referenced Apr 15, 2024
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for article_flag if a live or breaking article was coming through as uppercase. This PR changes it to lower case.
TDP-1777