Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scancode options in deltacode results #171

Merged
merged 1 commit into from Mar 11, 2022

Conversation

Pratikrocks
Copy link
Collaborator

@Pratikrocks Pratikrocks commented Jul 17, 2021

This PR is meant to provide details about the scancode_header_options present in the scancode scans.
Additionally we will have these options present now in the headers.
`

"deltacode_notice": "Generated with DeltaCode and provided on an \"AS IS\" BASIS, WITHOUT WARRANTIES\nOR CONDITIONS OF ANY KIND, either express or implied. No content created from\nDeltaCode should be considered or used as legal advice. Consult an Attorney\nfor any legal advice.\nDeltaCode is a free software codebase-comparison tool from nexB Inc. and others.\nVisit https://github.com/nexB/deltacode/ for support and download.",
"new_scan_options": {
  "input": [
    "/home/coala-0.10.0/coalib/"
  ],

  "--fingerprint": true,
  "--info": true,
  "--json-pp": "o.json"
},

"old_scan_options": {
  "input": [
    "/home/coala-0.10.0/coalib/"
  ],
  "--fingerprint": true,
  "--info": true,

  "--json-pp": "o.json"
},

`
Signed-off-by: Pratik Dey pratikrocks.dey11@gmail.com

Signed-off-by: Pratik Dey <pratikrocks.dey11@gmail.com>
Copy link
Contributor

@steven-esser steven-esser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this part of an issue?

@Pratikrocks
Copy link
Collaborator Author

No a part of an issue actually(till now) , I added these options since i felt it would provide some what more insights to the user scanning about the original options present in scancode json files

@Pratikrocks Pratikrocks linked an issue Jul 20, 2021 that may be closed by this pull request
@Pratikrocks
Copy link
Collaborator Author

There was an issue #2

@Pratikrocks Pratikrocks linked an issue Jul 20, 2021 that may be closed by this pull request
@pombredanne pombredanne changed the title scancode options in the deltacode results Add scancode options in deltacode results Aug 16, 2021
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging at last!

@pombredanne pombredanne merged commit aa713f8 into nexB:develop Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants