Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and determine ScanCode options present in a ScanCode data file #2

Closed
johnmhoran opened this issue Oct 28, 2017 · 5 comments · Fixed by #171
Closed

Check and determine ScanCode options present in a ScanCode data file #2

johnmhoran opened this issue Oct 28, 2017 · 5 comments · Fixed by #171
Assignees
@johnmhoran
Labels
bug easy enhancement GSOC Project/issues to be done during the GSOC Time frame
Milestone
1.1.0 Release

Comments

@johnmhoran
Copy link
Member

johnmhoran commented Oct 28, 2017 •
edited by pombredanne
Loading

In order to compare codebases accurately, Deltacode needs scancode data files that have the full file information available, at the very least.

We also need to know what additional scancode options each Deltacode input file has in order to figure out what other scan data is present and therefore what type of license, copyright or other data we can compare.
@johnmhoran johnmhoran self-assigned this Oct 28, 2017
@steven-esser steven-esser mentioned this issue Oct 31, 2017
Closed
@steven-esser
Copy link
Contributor

This needs a new field in the Scan object.

johnmhoran added a commit that referenced this issue Nov 1, 2017
@johnmhoran
Check options in incoming ScanCode files #2
7d10380 
  * Scan class 'get_options()' method adds options from
    'scancode_options' field as dictionary to 'options' attribute.

Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran added a commit that referenced this issue Nov 1, 2017
@johnmhoran
Merge branch 'develop' into 2-check-scancode-options #2
d907645 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran added a commit that referenced this issue Nov 1, 2017
@johnmhoran
Add 'options' field checks to other tests #2
ccce945 
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
steven-esser added a commit that referenced this issue Nov 1, 2017
@steven-esser
Merge pull request #13 from nexB/2-check-scancode-options
34a3033 
Check options in incoming ScanCode files #2
@steven-esser
Copy link
Contributor

merged, closing this ticket now.

@steven-esser
Copy link
Contributor

Re-Opening now that we account for license and copyright details.

@steven-esser steven-esser reopened this Mar 24, 2018
@steven-esser steven-esser added this to the 1.1.0 Release milestone Mar 24, 2018
@johnmhoran
Copy link
Member Author

👍

@johnmhoran johnmhoran mentioned this issue Mar 26, 2018
Closed
@arnav-mandal1234
Copy link
Collaborator

@MaJuRG Can you please explain me the issue?
I want to work on this issue. :)

@aboutcode-org aboutcode-org deleted a comment from johnmhoran Apr 4, 2019
@Pratikrocks Pratikrocks mentioned this issue Mar 19, 2020
Closed
steven-esser added a commit that referenced this issue Feb 17, 2021
@steven-esser
Follow modern python packaging and conf practices
9a56b88 
* Add PEP 517/518 pyproject.toml file
* Add setuptools_scm to handle versioning
* Add setup.py content to setup.cfg
* Update setup.py to act as a shim (so pip install -e works)

Addresses: #2

Signed-off-by: Steven Esser <sesser@nexb.com>
@Pratikrocks Pratikrocks added the GSOC Project/issues to be done during the GSOC Time frame label Jun 24, 2021
@Pratikrocks Pratikrocks mentioned this issue Jul 20, 2021
Merged
@Pratikrocks Pratikrocks linked a pull request Jul 20, 2021 that will close this issue
Add scancode options in deltacode results #171
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnmhoran johnmhoran

Labels
bug easy enhancement GSOC Project/issues to be done during the GSOC Time frame
Projects
None yet
Milestone
1.1.0 Release
Development

Successfully merging a pull request may close this issue.

Add scancode options in deltacode results Pratikrocks/deltacode
4 participants
@steven-esser @johnmhoran @arnav-mandal1234 @Pratikrocks