Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright and URLs data structure: Data structure inconsistency in results #2350

Closed
tdruez opened this issue Dec 11, 2020 · 4 comments
Closed

Copyright and URLs data structure: Data structure inconsistency in results #2350

tdruez opened this issue Dec 11, 2020 · 4 comments
Assignees
@NinaPacifier
Labels
bug

Comments

@tdruez
Copy link
Member

tdruez commented Dec 11, 2020

Description

copyrights, holders, authors use the value key where urls and emails use url and email as keys.

'urls': [{'url': 'http://pypi.python.org/pypi/python-cjson/1.0.5', 'end_line': 57, 'start_line': 57}]
'copyrights': [{'value': 'Copyright (c) 2009, by the authors', 'end_line': 4, 'start_line': 3}]
@tdruez tdruez added the bug label Dec 11, 2020
@NinaPacifier
Copy link

hey @tdruez Can I work on this issue??

@tdruez
Copy link
Member Author

tdruez commented Dec 14, 2020

@NinaPacifier Sure 👍

@akugarg
Copy link
Collaborator

akugarg commented Jan 16, 2021

Hey @tdruez !
If this issue is still open Can I work on this?

@tdruez
Copy link
Member Author

tdruez commented Jan 18, 2021

Hi @akugarg, yes PR welcome 👍

@akugarg akugarg mentioned this issue Jan 19, 2021
Closed
4 tasks
@akugarg akugarg mentioned this issue Feb 1, 2021
Closed
4 tasks
@pombredanne pombredanne changed the title Data structure inconsistency in results Copyright and URLs data structure: Data structure inconsistency in results Aug 20, 2021
@pombredanne pombredanne mentioned this issue Aug 20, 2021
Closed
pombredanne pushed a commit that referenced this issue Jan 9, 2022
@akugarg @pombredanne
Rename copyright keys for consistency #2350
ecca39a 
In copyright detection results, rename the "value" attribute to proper
descriptive names, respectively: copyright, holder and author

Signed-off-by: akugarg <akanksha.garg2k@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Jan 9, 2022
@pombredanne
Rename copyright keys for consistency #2350
92af231 
This second commit updates the tests and code that did not exist yet
at the time of the initial patch or code that failed to pass tests.

In copyright detection results, rename the "value" attribute to proper
descriptive names, respectively: copyright, holder and author.

Also:
- rename "copyright_holder" to "holder" in CSV output
- apply minor refactorings

Co-authorred-by: akugarg <akanksha.garg2k@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Jan 9, 2022
Merged
4 tasks
pombredanne added a commit that referenced this issue Jan 9, 2022
@pombredanne
Merge pull request #2791 from nexB/2350-improve-copyright-handling
28578ad 
Improve copyright handling #2350
@tdruez tdruez closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NinaPacifier NinaPacifier

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistency removed
Improve copryight data stucture consistency #2350
3 participants
@tdruez @akugarg @NinaPacifier