Improve copyright handling #2350 #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
In copyright detection results, rename the "value" attribute to proper descriptive names, respectively: copyright, holder and author Signed-off-by: akugarg <akanksha.garg2k@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This second commit updates the tests and code that did not exist yet at the time of the initial patch or code that failed to pass tests. In copyright detection results, rename the "value" attribute to proper descriptive names, respectively: copyright, holder and author. Also: - rename "copyright_holder" to "holder" in CSV output - apply minor refactorings Co-authorred-by: akugarg <akanksha.garg2k@gmail.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We now use a set of Detection objects to streamline how things are handled internally. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
4 tasks
|
All green ... merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve copyright data structure consistency for #2350
This is a rebase and finishing of #2381
Also streamlines internal handling of copyright using
Detection objects.
Tasks
Run tests locally to check for errors.