New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect license detected in CocoaLumberjack #2603
Labels
Comments
This is called https://scancode-licensedb.aboutcode.org/bsd-source-code.html and the missing disclaimer is not critical to make it a separate new license. |
pombredanne
added a commit
that referenced
this issue
Mar 11, 2022
This project has an odd licensing with a complicated history Reference: CocoaLumberjack/CocoaLumberjack#1116 Reference: CocoaLumberjack/CocoaLumberjack#936 Reference: CocoaLumberjack/CocoaLumberjack#696 Reference: #2551 Reference: #2603 Reported-by: Marcel Bochtler <marcel.bochtler@bosch.io> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is fixed in develop: {
"path": "CocoaLumberjack-master/Integration/Sources/AppDelegate.h",
"type": "file",
"detected_license_expression": "bsd-new AND bsd-source-code",
"detected_license_expression_spdx": "BSD-3-Clause AND BSD-Source-Code",
"license_detections": [
{
"license_expression": "bsd-new",
"detection_log": [
"not-combined"
],
"matches": [
{
"score": 99.0,
"start_line": 1,
"end_line": 1,
"matched_length": 5,
"match_coverage": 100.0,
"matcher": "2-aho",
"license_expression": "bsd-new",
"rule_identifier": "bsd-new_509.RULE",
"rule_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/bsd-new_509.RULE",
"referenced_filenames": [],
"is_license_text": false,
"is_license_notice": false,
"is_license_reference": true,
"is_license_tag": false,
"is_license_intro": false,
"rule_length": 5,
"rule_relevance": 99,
"matched_text": "// Software License Agreement (BSD License)",
"licenses": [
{
"key": "bsd-new",
"name": "BSD-3-Clause",
"short_name": "BSD-3-Clause",
"category": "Permissive",
"is_exception": false,
"is_unknown": false,
"owner": "Regents of the University of California",
"homepage_url": "http://www.opensource.org/licenses/BSD-3-Clause",
"text_url": "http://www.opensource.org/licenses/BSD-3-Clause",
"reference_url": "https://scancode-licensedb.aboutcode.org/bsd-new",
"scancode_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses/bsd-new.LICENSE",
"spdx_license_key": "BSD-3-Clause",
"spdx_url": "https://spdx.org/licenses/BSD-3-Clause"
}
]
}
]
},
{
"license_expression": "bsd-source-code",
"detection_log": [
"not-combined"
],
"matches": [
{
"score": 99.0,
"start_line": 6,
"end_line": 14,
"matched_length": 73,
"match_coverage": 100.0,
"matcher": "2-aho",
"license_expression": "bsd-source-code",
"rule_identifier": "bsd-source-code_11.RULE",
"rule_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/bsd-source-code_11.RULE",
"referenced_filenames": [],
"is_license_text": true,
"is_license_notice": false,
"is_license_reference": false,
"is_license_tag": false,
"is_license_intro": false,
"rule_length": 73,
"rule_relevance": 99,
"matched_text": "// Redistribution and use of this software in source and binary forms,\n// with or without modification, are permitted provided that the following conditions are met:\n//\n// * Redistributions of source code must retain the above copyright notice,\n// this list of conditions and the following disclaimer.\n//\n// * Neither the name of Deusty nor the names of its contributors may be used\n// to endorse or promote products derived from this software without specific\n// prior written permission of Deusty, LLC.",
"licenses": [
{
"key": "bsd-source-code",
"name": "BSD Source Code Attribution",
"short_name": "BSD Source Code Attribution",
"category": "Permissive",
"is_exception": false,
"is_unknown": false,
"owner": "TSRM",
"homepage_url": "https://github.com/infusion/PHP/blob/master/TSRM/LICENSE",
"text_url": "https://github.com/infusion/PHP/blob/master/TSRM/LICENSE",
"reference_url": "https://scancode-licensedb.aboutcode.org/bsd-source-code",
"scancode_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/licenses/bsd-source-code.LICENSE",
"spdx_license_key": "BSD-Source-Code",
"spdx_url": "https://spdx.org/licenses/BSD-Source-Code"
}
]
}
]
}
],
"license_clues": [],
"percentage_of_license_text": 77.23,
"package_data": [],
"for_packages": [],
"is_legal": false,
"is_manifest": false,
"is_readme": false,
"is_top_level": false,
"is_key_file": false,
"scan_errors": []
}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See https://github.com/CocoaLumberjack/CocoaLumberjack/blob/e518eb6e362df327574ba5e04269cd6d29f40aec/Integration/Sources/AppDelegate.h
We detected:
but the license is a subset of a bsd-new: clause 1 and 3, minus a disclaimer
Yet otherwise the root license is a bsd-new:
https://github.com/CocoaLumberjack/CocoaLumberjack/blob/4eacc74ce77aae3282898101827f5b62731a379c/LICENSE
The text was updated successfully, but these errors were encountered: