Fix incorrect license detection #2777 #2811
Conversation
|
@pombredanne the one test that fails after applying this change is the exact same bug reported in #2777. The expected output for the test is located on line 3 of Does this mean the test's expected output is incorrect? If it is, I can also fix the test. Or is #2777 actually not a bug? |
|
@KevinJi22 This is not a clear cut... See #2777 (comment) |
Adds a false positive rule for GNU tar. Fixes nexB#2777 Signed-off-by: Kevin Ji <kyji1011@gmail.com>
This removes the public domain license that was previously one of the expected outputs of the Debian Slim Copyright license detection test. The public domain license is not an actual license for this GNU tar file. Signed-off-by: Kevin Ji <kyji1011@gmail.com>
KevinJi22
force-pushed
the
false-positive-2777
branch
from
8a0e4f0
to
b0b63a6
Compare
|
@KevinJi22 this is a bug alright as documented in #2777 (comment) |
|
@pombredanne Yup, I fixed the bug in the second commit by removing the public domain license as one of the test's expected outputs. |
There was a problem hiding this comment.
the failure in https://github.com/nexB/scancode-toolkit/runs/5010476784?check_suite_focus=true is not your making. Looking all good... Merging now!
Thank you ++
Adds a false positive rule for GNU tar. Also removes the public domain license as one of the expected outputs of the Debian slim copyright license test because the test has the same bug as the linked issue. Fixes #2777.
Tasks
Run tests locally to check for errors.