Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Going to file, via links in explorers, doesn't scroll to the file in the FileTree #590

Closed
OmkarPh opened this issue Jul 28, 2023 · 1 comment · Fixed by #599
Closed

Going to file, via links in explorers, doesn't scroll to the file in the FileTree #590

OmkarPh opened this issue Jul 28, 2023 · 1 comment · Fixed by #599
Labels

Comments

@OmkarPh
Copy link
Collaborator

OmkarPh commented Jul 28, 2023

Description

The issue occurs when the specific path is deep & there are lots of entries to render,
The scrollToElement function is running before its rendered, hence it's unable to find that element

This can be reproduced by importing this scan: analysis-icu.json.txt

Go to Licenses Explorer > License Clues > ngpl > Click on path in file region table analysis-icu/icu4j-62.1.jar-extract/com/ibm/icu/impl/data/icudt62b/supplementalData.res

This takes the user to TableView, and after processing for a couple of seconds, shows the Tableview with respect to it
However, the path explorer isn't focused onto this path.

Ideal fix is to call the scrollToElement, only after the updated FileTree is rendered completely

@OmkarPh
Copy link
Collaborator Author

OmkarPh commented Oct 2, 2023

Closing the issue as it is fixed now

@OmkarPh OmkarPh closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant