Fixed corrupting excel file after repairing files by `nexial-artifact…

…-repair.cmd|sh`. Set max row-col limit as 10000 to read/write excel.

src/main/java/org/nexial/core/NexialConst.java

@@ -946,6 +946,8 @@ public static final class Data {
         public static final String SHEET_MERGED_DATA = "#data";
         public static final String SHEET_DEFAULT_DATA = "#default";
         public static final boolean DEF_OPEN_EXCEL_AS_DUP = IS_OS_WINDOWS;
+        // maximum row-column limit to read/write data
+        public static final int EXCEL_ROW_COL_MAX_LIMIT = 10000;
 
         // step
         public static final String STEP_RESPONSE = NAMESPACE + "step.response";

src/main/kotlin/org/nexial/core/tools/repairExcel/ExcelUtils.kt

@@ -24,6 +24,7 @@ import org.apache.poi.xssf.usermodel.XSSFRow
 import org.apache.poi.xssf.usermodel.XSSFSheet
 import org.apache.poi.xssf.usermodel.XSSFWorkbook
 import org.nexial.core.NexialConst.DF_TIMESTAMP
+import org.nexial.core.NexialConst.Data.EXCEL_ROW_COL_MAX_LIMIT
 import org.nexial.core.excel.Excel
 import org.nexial.core.excel.ExcelConfig.StyleConfig.STRIKEOUT_COMMAND
 import org.nexial.core.excel.ExcelConfig.StyleDecorator
@@ -33,6 +34,7 @@ import org.nexial.core.tools.repairExcel.RepairExcels.ArtifactType
 import org.nexial.core.tools.repairExcel.RepairExcels.ArtifactType.*
 import org.nexial.core.tools.repairExcel.RepairExcels.TEMP_SHEET_NAME
 import org.nexial.core.tools.repairExcel.RepairExcels.retrieveValidSheet
+import org.nexial.core.utils.ConsoleUtils
 import org.springframework.util.CollectionUtils
 import java.io.File
 import java.io.File.separator
@@ -100,6 +102,8 @@ object ExcelUtils {
         val sheetName = sourceSheet.sheetName
         val tempSheetIndex = targetWorkbook.getSheetIndex(TEMP_SHEET_NAME)
         val targetSheet = targetWorkbook.cloneSheet(tempSheetIndex, sheetName)
+        // set maximum row limit to read data
+        val lastDataRow = if (lastDataRow < EXCEL_ROW_COL_MAX_LIMIT) lastDataRow else EXCEL_ROW_COL_MAX_LIMIT
 
         var destRowIndex = 0
         for (rowIndex in 0 until lastDataRow) {
@@ -121,7 +125,11 @@ object ExcelUtils {
      * @param fileType [ArtifactType] type of file. By default it is [DATA]
      */
     fun copyRow(sourceRow: XSSFRow, newRow: XSSFRow, fileType: ArtifactType = DATA) {
-        val lastDataColumn = RepairExcels.lastColumnIdx(sourceRow, fileType)
+        var lastDataColumn = RepairExcels.lastColumnIdx(sourceRow, fileType)
+        // set column index as max limit
+        if (lastDataColumn > EXCEL_ROW_COL_MAX_LIMIT) {
+            lastDataColumn = EXCEL_ROW_COL_MAX_LIMIT
+        }
 
         for (columnIndex in 0 until lastDataColumn + 1) {
             val oldCell = sourceRow.getCell(columnIndex)
@@ -170,24 +178,40 @@ object ExcelUtils {
     @Throws(IOException::class)
     private fun saveFile(file: File, preview: String?, targetWorkbook: XSSFWorkbook): RepairArtifactLog? {
         var action = "processed (not changed)"
-        val destFile: File
+        var destFile = file
+        val backupOrPreviewLoc: File
 
         if (preview != null) {
             // create folder structure as it is from searchFrom
             var fileSuffix = file.name
             if (file.absolutePath != searchFrom) {
                 fileSuffix = StringUtils.substringAfterLast(file.absolutePath, searchFrom).removePrefix(separator)
             }
-            destFile = File(StringUtils.appendIfMissing(preview, separator) + fileSuffix)
-            Excel.save(destFile, targetWorkbook)
+            backupOrPreviewLoc = File(StringUtils.appendIfMissing(preview, separator) + fileSuffix)
+            destFile = backupOrPreviewLoc
         } else {
-            destFile = File("${file.absolutePath}.$runId")
-            FileUtils.moveFile(file, destFile)
-            action = "processed (changed)"
-            Excel.save(file, targetWorkbook)
+            backupOrPreviewLoc = File("${file.absolutePath}.$runId")
+            try {
+                FileUtils.moveFile(file, backupOrPreviewLoc)
+            } catch (e: IOException) {
+                ConsoleUtils.error("Unable to create backup; File '${file.absolutePath}'" +
+                                   " might being used by another process ")
+                log(action, file)
+                return null
+            }
         }
+
+        val repairArtifactLog: RepairArtifactLog? =
+            try {
+                Excel.save(destFile, targetWorkbook)
+                action = "processed (changed)"
+                RepairArtifactLog(file, 0, backupOrPreviewLoc)
+            } catch (e: IOException) {
+                ConsoleUtils.error("Unable to repair excel as ${e.message}")
+                null
+            }
         log(action, file)
-        return RepairArtifactLog(file, 0, destFile)
+        return repairArtifactLog
     }
 
     private fun getRow(sheet: XSSFSheet, rowNum: Int) = sheet.getRow(rowNum) ?: sheet.createRow(rowNum)

src/main/kotlin/org/nexial/core/tools/repairExcel/RepairArtifact.kt

@@ -97,12 +97,13 @@ object RepairArtifact {
         println("|" + ConsoleUtils.centerPrompt(prompt, 120) + "|")
         println("\\$banner/")
         repairArtifact()
+        println()
+        println("$banner--")
 
         if (repaired.isEmpty()) {
             println(ConsoleUtils.centerPrompt("There are no matching files.", 122))
-        } else {
-            println()
             println("$banner--")
+        } else {
             println(formatColumns("File", "Process Time", column3Name))
             println("$banner--")
             repaired.forEach { println(it) }
@@ -167,7 +168,7 @@ object RepairArtifact {
             val sheet = targetSheet.sheet
             val row = sheet.getRow(i)
             val lastColumnIdx = lastColumnIdx(row, fileType)
-            for (cellIndex   in 0 until lastColumnIdx + 1) {
+            for (cellIndex in 0 until lastColumnIdx + 1) {
                 val cell = row.getCell(cellIndex) ?: continue
                 cell.setCellValue("")
             }