feature(domain): create domain(Session, Student, Students) #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csh0034
requested changes
Dec 2, 2023
csh0034
requested changes
Dec 6, 2023
| import java.sql.Timestamp; | ||
|
|
||
| public class SessionDate { | ||
| private Timestamp startDate; |
There was a problem hiding this comment.
Date 하위타입인 Timestamp 보다 java1.8 에 추가된 LocalDateTime 을
사용해보면 좋을것 같아요!
| } | ||
|
|
||
| public NsUser add(NsUser nsUser) { | ||
| students.stream() |
There was a problem hiding this comment.
contains 메서드를 활용해볼수 있지 않을까요?
추가로 NsUser 에 equals hashCode 가 구현되어있지 않은데
정상동작하는걸까요? 🤔
| @@ -0,0 +1,49 @@ | |||
| package nextstep.session.domain; | |||
|
|
|||
| public class CoverImage { | |||
There was a problem hiding this comment.
별도 테이블로 구성되도록 해주셨네요.
강의는 강의 커버 이미지가 있어야하므로 하나의 테이블에서 VO 를 선언해보는것도
좋을것 같아요.
크기(용량), 타입, 가로세로 를 가지는도록 하고 각각 원시값 wrapping 을 해보면 좋을것 같습니다.
|
|
||
| private void checkImage () { | ||
| String extension = name.split("\\.")[1]; | ||
| if(!("gif".equals(extension) || "png".equals(extension) || "jpg".equals(extension) || "jpeg".equals(extension))) { |
| throw new IllegalArgumentException("수강신청은 모집중일때만 가능합니다."); | ||
| } | ||
| if (type == SessionType.CHARGE) { | ||
| if (checkMaxStudent()) { |
| private int price; | ||
| private int maxStudent; | ||
| private CoverImage coverImage; | ||
| private Students students = new Students(new ArrayList<>()); |
There was a problem hiding this comment.
Students 에 인자없는 생성자를 추가하여 new ArrayList<>() 를 할당해볼수도 있겠네요!
| if(!("gif".equals(extension) || "png".equals(extension) || "jpg".equals(extension) || "jpeg".equals(extension))) { | ||
| throw new IllegalArgumentException("gif, png, jpg, jpeg 파일만 업로드 가능합니다."); | ||
| } | ||
| if(size > 1024 * 1024) { |
| private Long courceId; | ||
| private SessionDate sessionDate; | ||
| private SessionType type; | ||
| private int price; |
There was a problem hiding this comment.
수강료와 최대 수강인원 등은 원시값 wrapping 을 적용해보면 좋을것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step2 PR 요청합니다.