Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use NodeNext module resolution #9953

Merged
merged 29 commits into from
Jun 1, 2024
Merged

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 7, 2024

TODO

Related: #9917, #9883, #9844 and more...

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 11:10am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 11:10am
nextra-docs ⬜️ Ignored (Inspect) Jun 1, 2024 11:10am
proxy ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 11:10am

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters dgraph @auth/dgraph-adapter xata @auth/xata-adapter next-auth d1 labels Feb 7, 2024
Copy link

socket-security bot commented Feb 7, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ndom91
Copy link
Member

ndom91 commented May 14, 2024

Fixed up a few small things, but theres still a lingering build issue apparently. See the Build step output in this job.

Looks like it can't find the types imported from @simplewebauthn/server/script/deps. In my local installation though, node_modules/@simplewebauthn/server/script/deps.d.ts definitely does export the types we're trying to import 🤔

Changing the imports to add a .js or .d.ts extension doesn't seem to help

image

@ndom91
Copy link
Member

ndom91 commented May 21, 2024

Looks like there's a separate @simplewebauthn/types package that they publish which exports all the required types we needed

@ndom91
Copy link
Member

ndom91 commented May 21, 2024

@balazsorban44 Xata had some larger issues, I updated the pkg and updated the affected types. Tested it with a Xata project manually and it all seems to work still 🤞

Dgraph and @SimpleWebAuthn just needed some smaller TS fixes to build again, but those are working now too. The whole thing builds again now. Imo good to merge!

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.75%. Comparing base (0b321a0) to head (39cc6cf).

Files Patch % Lines
packages/core/src/lib/utils/webauthn-client.js 18.75% 13 Missing ⚠️
packages/next-auth/src/lib/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9953      +/-   ##
==========================================
- Coverage   40.75%   40.75%   -0.01%     
==========================================
  Files         177      177              
  Lines       28031    28038       +7     
  Branches     1244     1244              
==========================================
+ Hits        11424    11426       +2     
- Misses      16607    16612       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 577b7f9 into main Jun 1, 2024
13 of 15 checks passed
@ndom91 ndom91 deleted the chore/nodnext-module-resolution branch June 1, 2024 11:07
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
Co-authored-by: Nico Domino <yo@ndo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` d1 dgraph @auth/dgraph-adapter drizzle @auth/drizzle-adapter next-auth xata @auth/xata-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants