-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch node modules next headers not found #10302 #10304
Conversation
…eaders-not-found Patch node modules next headers not found
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@OpenTextASOWSM is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Hi, anyone can review/approve? Seems to be effecting others. |
Can someone review this pr? It solved my problem in locally. |
I was just hitting this issue. From what I see, everyone that uses /pages in Next.js that use auth() function within getServerSideProps() is affected. Thanks for the PR! :-) Can this be merged? |
@ThangHuuVu can you review? as a work around until merged might work.... worked for others ' this was fixed by transpiling next-auth in next.config.js { ' |
While this may work, I have a feeling this is not the best way to go about this, changing the |
Hey folks, so I talked to the team and theres another PR open that should take care of this as well actually. Looks like its only (hopefully temporarily) necessary for Anywayy, I'd appreciate if you guys could test if this PR fixes your issues as well and then we can merge that one 🙏 |
@ndom91 It looks like all three changes from this PR are a subset of where they found this issue in next-auth. It looks like they are doing the same thing... there were already cases like in packages/next-auth/src/lib/index.ts where the next-auth code was specifying .js for inclusions for env.js and actions.js both the PRs try to address it by following that pattern. I'm not in a postion to test again for some time. |
looks like the merge of the other code is blocked by security issue, if that isn't resolvable quickly since it's been 2 months maybe you can merge this. |
@OpenTextASOWSM thanks for the quick response. Yeah so we were using this for internal imports already, for sure. But using it for external, i.e. 3rd party, packages is what feels wrong to me / the team. Unfortunately it does seem to be necessary atm for I cleaned up that other PR a bit so there are no more merge conflicts and theoretically it should be good to go 🙏 Woudl still appreciate some feedback from anyone else if they ran into this issue and coudl test that other PR to see if it fixes it for them without introducing any other issues |
This is not the correct solution. third-party imports should not need an import specifier. The issue here is that Next.js currently does not have an |
☕️ Reasoning
This is the fix described in -
#10302
seems a reasonable number of people are hitting this issue.
#9385
🧢 Checklist
🎫 Affected issues
Cannot find module node_modules\next\headers - 10302
📌 Resources
#9385