-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use NodeNext
module resolution
#9953
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Fixed up a few small things, but theres still a lingering build issue apparently. See the Looks like it can't find the types imported from Changing the imports to add a |
Looks like there's a separate |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/react@18.3.3, npm/autoprefixer@10.4.19, npm/class-variance-authority@0.7.0, npm/clsx@2.1.1, npm/lucide-react@0.274.0, npm/next@14.2.3, npm/postcss@8.4.38, npm/react-dom@18.3.1, npm/react@18.3.1, npm/solid-js@1.8.17, npm/solid-start-node@0.2.32, npm/solid-start-vercel@0.2.32, npm/solid-start@0.2.32, npm/tailwindcss@3.4.3, npm/typescript@5.2.2, npm/vite@3.2.10 |
@balazsorban44 Xata had some larger issues, I updated the pkg and updated the affected types. Tested it with a Xata project manually and it all seems to work still 🤞 Dgraph and @SimpleWebAuthn just needed some smaller TS fixes to build again, but those are working now too. The whole thing builds again now. Imo good to merge! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9953 +/- ##
==========================================
- Coverage 40.75% 40.75% -0.01%
==========================================
Files 177 177
Lines 28031 28038 +7
Branches 1244 1244
==========================================
+ Hits 11424 11426 +2
- Misses 16607 16612 +5 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Nico Domino <yo@ndo.dev>
Co-authored-by: Nico Domino <yo@ndo.dev>
TODO
Related: #9917, #9883, #9844 and more...