Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): enable pnpm caching in CI #7332

Closed
wants to merge 2 commits into from
Closed

feat(ci): enable pnpm caching in CI #7332

wants to merge 2 commits into from

Conversation

SauravMaheshkar
Copy link
Contributor

Changes made by this PR can be summarized as follows:

  • Set the cache and cache-dependency-path argument to enable caching to speed up CI times.

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2023 11:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Apr 22, 2023 11:24am

@vercel
Copy link

vercel bot commented Apr 21, 2023

@SauravMaheshkar is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@balazsorban44
Copy link
Member

Thanks, but based on #6939 this actually showed a slowdown. 🤔

@SauravMaheshkar
Copy link
Contributor Author

Thanks, but based on #6939 this actually showed a slowdown. 🤔

Ah sorry missed the PR. Closing this

@SauravMaheshkar SauravMaheshkar deleted the ci-pnpm-cache branch April 22, 2023 21:25
@AlexErrant
Copy link

FWIW I left a comment on that PR that described why their analysis was flawed.

balazsorban44 added a commit that referenced this pull request Jun 1, 2023
@balazsorban44
Copy link
Member

FYI, I re-added caching as I can see node_modules being installed on every run, and I'm leaning towards that #6939 (comment) is a true statement.

balazsorban44 added a commit that referenced this pull request Jun 1, 2023
@balazsorban44
Copy link
Member

With cache (restore 19s + install 24s = total 43s): https://github.com/nextauthjs/next-auth/actions/runs/5144534075/jobs/9260949734

Without cache (restore 0s + install 86s = total 86s): https://github.com/nextauthjs/next-auth/actions/runs/5144363220/jobs/9260563249

Not sure why there was 24s of install with cache, but still 2x the speed, so the cache is definitely worth it!

Duh... :facepalm: Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants