-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): disable node cache to speed up ci #6939
Conversation
in my experience restoring and storing cache costs so much time, that the (tiny) gain during install is gone. this tries to prove that for next-auth.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting observation. We should have a deeper look into our CI at some point. We often have cache misses for the docs build as well.
We can merge this for now and see. Thanks!
In your "before", the workflow file says In my own project (not a fork of NextAuth), caching is faster. Here's a screenshot of my own project showing how the cache improves overall |
@balazsorban44 thoughts on this 👀 ? |
Gonna guess he doesn't care that much about a CI speedup. If you care, you could fork, run it in your own repo, and come back with empirical runtimes. |
☕️ Reasoning
in my experience restoring and storing cache costs so much time, that the (tiny if even) gain during install is gone. this tries to prove that for next-auth.
before:
install: 1m 16s
post-setup: 1m 44s
after:
install: 1m 11s
post-setup: 0s
... also yamllint complaint about redundant string indicators.
🧢 Checklist