feat: simplify NextAuth instantiation #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/48kcjhjdf |
balazsorban44
changed the title
balazsorban44
added a commit
that referenced
this pull request
Dec 5, 2020
This reverts commit b86ffa5.
|
Great change! Typings should be updated accordingly in the DefinitelyTyped project, so TypeScript users may also benefit from this change. |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import NextAuth from 'next-auth' const options = { //... } - export default (req, res) => NextAuth(req, res, options) + export default NextAuth(options)We could simplify the
NextAuthinstance even further, by checking the number of arguments. If there is only one argument, the default function inserver/index.jscould return aNextApiHandler. Otherwise preserve the current behaviour, for backwards compatibility.Fixes #868