Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: simplify NextAuth instantiation" #910

Merged
merged 1 commit into from Dec 5, 2020

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Dec 5, 2020

Reverts #867

Vercel will deploy the docs from main. If I add some new functionality and I document it, the docs will automatically update https://next-auth.js.org/, while the latest npm package won't reflect it.

@iaincollins we should either change the behaviour of Vercel docs deployments, or set up a canary branch.

Or I could just not document anything while adding features, then we have to remember to do it before releasing latest to npm.

The best option seems to just set up a canary branch, and change PR bases to that, as we talked about it earlier.

Reverting this PR for now, and reopened it on #911.

@vercel
Copy link

vercel bot commented Dec 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/8wy088icz
✅ Preview: https://next-auth-git-revert-867-patch-2.nextauthjs.vercel.app

@balazsorban44 balazsorban44 merged commit 341fae2 into main Dec 5, 2020
@balazsorban44 balazsorban44 deleted the revert-867-patch-2 branch December 5, 2020 09:39
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant