Create first config

[skjnldsv]

From https://github.com/skjnldsv/vueexample/blob/master/.eslintrc.js

See working example skjnldsv/vueexample#249

[nickvergessen]

So after this is in, how can I get it into nextcloud/notifications#432 ?

[skjnldsv]

So after this is in, how can I get it into nextcloud/notifications#432 ?

See https://github.com/skjnldsv/vueexample/pull/249/files :)

[georgehrke]

@skjnldsv-bot publish npm

[skjnldsv]

@georgehrke Still a few things to finish, the peerdependencies mostly, to avoid other apps updating their packages if the config does not support it

[korelstar]

Hi everybody! A common config is good, but why did you created a new repository for this? We have already https://github.com/nextcloud/eslint-plugin-nextcloud which could be enhanced with a new config!?

[skjnldsv]

This is very different.
A plugin provide rules with methods to properly check against.
This is just a config set. Same goes for eslint-config-standard and eslint-plugin-standard

[korelstar]

eslint-plugin-nextcloud contains a config set, too: https://github.com/nextcloud/eslint-plugin-nextcloud/tree/master/lib/configs

I still don't see, why this needs to be separated.

[skjnldsv]

But a plugin only depends on its own configs :)
see https://eslint.org/docs/developer-guide/shareable-configs

[korelstar]

You can use those configs directly from your custom app. That's what I'm doing in the notes app: https://github.com/nextcloud/notes/blob/master/.eslintrc.js#L22

We can move all that stuff to a new config inside of eslint-plugin-nextcloud and use this config in every app.

[skjnldsv]

Looks like a very bad idea to me.
the eslint-config-nextcloud also implements custom dependencies for webpack and vuejs. the esling plugin is a standalone. This should not be mixed.

If we do that, suddenly we get into a very messy dependency management where we have the config requiring webpack, eslint-vue... deps that are not required at all by the plugin (originally).

[skjnldsv]

All working fine @georgehrke

$ npm i --save-dev eslint@6.0.0                  
npm WARN eslint-config-nextcloud@0.0.5 requires a peer of eslint@^5.0.0 but none is installed. You must install peer dependencies yourself.

@korelstar any reason you seems to be against this new package?

[korelstar]

I just didn't see the advantage for a separate package (which just means more maintainance overhead). Furthermore, the current implementation contains definitions, we already have in eslint-plugin-nextcloud (e.g. globals).

[skjnldsv]

Well, I follow eslint guidelines and don't want to pollute the main plugin which is supposed to provide dedicated nextcloud rules.
Ho wis that more maintenance? It is cleaned up on your apps, less packages, you get assurance of compatibility since dependabot won't suggest updates as long as our eslint package don't support it.

All I see is less thing to do for you!