Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint/@nextcloud #899

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Eslint/@nextcloud #899

merged 4 commits into from
Mar 25, 2020

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 3, 2020

No description provided.

@skjnldsv skjnldsv added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Mar 3, 2020
@skjnldsv skjnldsv self-assigned this Mar 3, 2020
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 3, 2020
marcoambrosini
marcoambrosini approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very related but... Closing bracket on a new line for nicer diffs and clearer structure :D ????

<MyComponent
    prop1="value1"
    prop2="value2"
/>

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Mar 3, 2020 •
edited
Loading

Not very related but... Closing bracket on a new line for nicer diffs and clearer structure :D ????

let's not have this discussion again please 😅
nextcloud-libraries/eslint-config#1
nextcloud-libraries/eslint-config#8

@marcoambrosini
Copy link
Contributor

let's not have this discussion again please sweat_smile

I had to try 😅

@marcoambrosini
Copy link
Contributor

nextcloud-libraries/eslint-config#8

Oh I wasn't aware of this, I would certainly have lobbied for it :)

@juliushaertl
Copy link
Contributor

Hmm, CI is not that happy 😉

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Mar 3, 2020

Hmm, CI is not that happy

Yeah, there is some linting fix to finish ;)

@juliushaertl
Copy link
Contributor

Ah I was just following the crowd of reviewers and ignoring the 2. developing 🙈

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Mar 6, 2020

Should be good to go :)
Lots of warning Using exported name 'ActionButton' as identifier for default export import/no-named-as-default Maybe we could disable this, I think it's to avoid typos ?

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2020
@skjnldsv
Copy link
Contributor Author

skjnldsv commented Mar 6, 2020

@juliushaertl @ChristophWurst any of you know why the l10n action is failing?

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 6, 2020
@ChristophWurst
Copy link
Contributor

@juliushaertl @ChristophWurst any of you know why the l10n action is failing?

Because you changed source files and thus the line references need an update

@skjnldsv
Move to @nextcloud/eslint
678ef8e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Stop using aliases
fb6f5a1 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix import/no-named-as-default
8b3e1f1 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Bump l10n
cbac272 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit ff5d0e9 into master Mar 25, 2020
@skjnldsv skjnldsv deleted the eslint/@nextcloud branch March 25, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@korelstar korelstar Awaiting requested review from korelstar

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @marcoambrosini @juliushaertl @ChristophWurst