New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove eslint-plugin-standard #103
Conversation
Signed-off-by: dartcafe <github@dartcafe.de>
10740bc
to
795e52c
Compare
@skjnldsv How are the rules, does the author of the PR the merge after review or someone like a release manager? |
You can merge :) |
Then you edit the CHANGELOG, and tag a new release with npm version and push --tags |
@skjnldsv Hope, I did as expected. BTW: 5.0.0 changelog is missing. 😉 Hmmm. I guess, I did somethin wrong. I tried to push the changelog and the version update to the master branch, but is was rejected (understandable). Sorry to spam this PR The package seems to be ok, but how does the tree https://github.com/nextcloud/eslint-config/tree/v5.1.0 get merged to the master branch?? |
You should have done the changelog before the npm version. But creating a release automatically compile and publish the release to npm 🙈 |
I changed the changelog and did an The release package here is created from the tag and contains version 5.1.0. The package on npm still countains version 5.0.0. |
Yes. Learned that now... 😉 |
Time to merge and release 5.1.1 🙈 |
Who? Me? Serious???? I don't grant for anything. 🤣 |
fix #101