Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove eslint-plugin-standard #103

Merged
merged 1 commit into from May 1, 2021
Merged

Conversation

dartcafe
Copy link
Contributor

fix #101

@dartcafe dartcafe added the dependencies Pull requests that update a dependency file label Apr 25, 2021
@dartcafe dartcafe requested a review from skjnldsv April 25, 2021 20:44
@dartcafe dartcafe changed the title remove eslint-plugin-standard #101 remove eslint-plugin-standard Apr 25, 2021
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe force-pushed the dep/remove-eslint-plugin-standard branch from 10740bc to 795e52c Compare April 26, 2021 07:37
@dartcafe
Copy link
Contributor Author

@skjnldsv How are the rules, does the author of the PR the merge after review or someone like a release manager?

@skjnldsv
Copy link
Contributor

You can merge :)

@skjnldsv
Copy link
Contributor

Then you edit the CHANGELOG, and tag a new release with npm version and push --tags

@dartcafe dartcafe merged commit 70db3d8 into master May 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the dep/remove-eslint-plugin-standard branch May 1, 2021 08:38
@dartcafe
Copy link
Contributor Author

dartcafe commented May 1, 2021

@skjnldsv Hope, I did as expected. BTW: 5.0.0 changelog is missing. 😉

Hmmm. I guess, I did somethin wrong. I tried to push the changelog and the version update to the master branch, but is was rejected (understandable). As a result the package has a wrong version number (still 5.0.0)

Sorry to spam this PR The package seems to be ok, but how does the tree https://github.com/nextcloud/eslint-config/tree/v5.1.0 get merged to the master branch??

@skjnldsv
Copy link
Contributor

skjnldsv commented May 2, 2021

Hmmm. I guess, I did somethin wrong. I tried to push the changelog and the version update to the master branch, but is was rejected (understandable). As a result the package has a wrong version number (still 5.0.0)

You should have done the changelog before the npm version.
Then you need to push the commit straight to master.
Or create a pr and once it's merged, create a release tagging the current master.

But creating a release automatically compile and publish the release to npm 🙈

@dartcafe
Copy link
Contributor Author

dartcafe commented May 3, 2021

I changed the changelog and did an npm version minor followed by push --tags. Trying to push to the master branch was rejected (no access?). Therefore I created #111.

The release package here is created from the tag and contains version 5.1.0. The package on npm still countains version 5.0.0.

@dartcafe
Copy link
Contributor Author

dartcafe commented May 3, 2021

But creating a release automatically compile and publish the release to npm 🙈

Yes. Learned that now... 😉

@skjnldsv
Copy link
Contributor

skjnldsv commented May 3, 2021

The package on npm still countains version 5.0.0

Time to merge and release 5.1.1 🙈

@dartcafe
Copy link
Contributor Author

dartcafe commented May 3, 2021

Time to merge and release 5.1.1

Who? Me? Serious???? I don't grant for anything. 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is eslint-plugin-standard still necessary as peerDependency?
2 participants