Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version and changelog #111

Merged
merged 4 commits into from May 10, 2021
Merged

fix version and changelog #111

merged 4 commits into from May 10, 2021

Conversation

dartcafe
Copy link
Contributor

@dartcafe dartcafe commented May 1, 2021

Signed-off-by: dartcafe github@dartcafe.de

@dartcafe dartcafe requested a review from skjnldsv May 1, 2021 09:34
@dartcafe dartcafe marked this pull request as draft May 1, 2021 10:24
@skjnldsv
Copy link
Contributor

skjnldsv commented May 2, 2021

A bit too simple 🙈

Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a better output than this please :)

CHANGELOG.md Outdated Show resolved Hide resolved
@dartcafe
Copy link
Contributor Author

dartcafe commented May 3, 2021

Agree. But this made me hoping, the changelog gets generated automatically:

  • This Changelog was automatically generated by github_changelog_generator

@skjnldsv
Copy link
Contributor

skjnldsv commented May 3, 2021

  • This Changelog was automatically generated by github_changelog_generator

It is :)
.....locally

@dartcafe dartcafe changed the title changelog v5.1.0 fix version and changelog May 7, 2021
@dartcafe dartcafe marked this pull request as ready for review May 7, 2021 06:39
@dartcafe dartcafe requested a review from skjnldsv May 7, 2021 06:40
@dartcafe
Copy link
Contributor Author

dartcafe commented May 7, 2021

It is :)
.....locally

And you wanted to let me type this manually? 😄

@skjnldsv
Copy link
Contributor

skjnldsv commented May 7, 2021

And you wanted to let me type this manually?

I would have also approved without the deps list lol :)

CHANGELOG.md Show resolved Hide resolved
dartcafe and others added 4 commits May 8, 2021 10:33
Signed-off-by: dartcafe <github@dartcafe.de>
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
Signed-off-by: dartcafe <github@dartcafe.de>
@skjnldsv skjnldsv merged commit d1daa0b into master May 10, 2021
@skjnldsv skjnldsv deleted the changelog-v5.1.0 branch May 10, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants