Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-menu): Allow to set the category for entries #952

Merged
merged 1 commit into from
May 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 16, 2024

Required for the last part of: nextcloud/server#43728

@susnux susnux added enhancement New feature or request 3. to review labels May 16, 2024
@susnux susnux requested review from skjnldsv, Pytal and ShGKme May 16, 2024 18:19
lib/newFileMenu.ts Outdated Show resolved Hide resolved
@susnux susnux force-pushed the feat/new-menu-allow-setting-category branch from 5886df7 to 9d59fc5 Compare May 16, 2024 18:42
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (82d6d41) to head (5886df7).
Report is 54 commits behind head on main.

❗ Current head 5886df7 differs from pull request most recent head 9d59fc5. Consider uploading reports for the commit 9d59fc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   77.57%   78.70%   +1.13%     
==========================================
  Files          17       17              
  Lines         446      465      +19     
  Branches      118      118              
==========================================
+ Hits          346      366      +20     
+ Misses         99       98       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feat/new-menu-allow-setting-category branch from 9d59fc5 to 005df94 Compare May 16, 2024 18:49
@susnux susnux merged commit b9b645b into main May 16, 2024
14 checks passed
@susnux susnux deleted the feat/new-menu-allow-setting-category branch May 16, 2024 18:51
@skjnldsv
Copy link
Contributor

🎉🎉

@skjnldsv skjnldsv mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants