Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Set status in davResultToNode when fileid is negative #985

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 13, 2024

A negative fileid is returned by Nextcloud when something internally went wrong. In this case we should set the Node.status by default.

@susnux susnux added bug Something isn't working 3. to review labels Jun 13, 2024
@susnux susnux requested review from skjnldsv and Pytal June 13, 2024 13:24
Copy link

codecov bot commented Jun 13, 2024

Bundle Report

Changes will increase total bundle size by 224 bytes ⬆️

Bundle name Size Change
@nextcloud/files-esm 94.45kB 112 bytes ⬆️
@nextcloud/files-esm-cjs 95.48kB 112 bytes ⬆️

A negative fileid is returned by Nextcloud when something internally went wrong.
In this case we should set the Node.status by default.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit fcdc007 into main Jun 13, 2024
17 checks passed
@skjnldsv skjnldsv deleted the fix/set-node-status branch June 13, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants