fix(files): Bring back handling of failed files #45860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/files-handle-failed-state
branch
from
f3523e2
to
061174d
Compare
|
Best with, but no blocker: nextcloud-libraries/nextcloud-files#985 |
Fenn-CS
approved these changes
Jun 13, 2024
4 tasks
susnux
force-pushed
the
fix/files-handle-failed-state
branch
from
061174d
to
7fec223
Compare
|
/compile |
When files are loaded from API the `fileid` might be set to `-1` indicating an error on the API. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-handle-failed-state
branch
from
972efeb
to
0bd7c76
Compare
artonge
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/filesfunctions where possible and make files views cancelable #45788Summary
The fileid might be set to -1 in case of an error, this brings back proper handling of this case.
Checklist