Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exact links in AppNavigationItem should be optional #29

Closed
ChristophWurst opened this issue Sep 20, 2018 · 1 comment
Closed

Exact links in AppNavigationItem should be optional #29

ChristophWurst opened this issue Sep 20, 2018 · 1 comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@ChristophWurst
Copy link
Contributor

Ref https://github.com/nextcloud/vue-components/blob/bda5feb8910d8e7aeee35a21bc1de9aa7dd95f92/src/components/AppNavigation/AppNavigationItem.vue#L160.

In mail, we have routes like /accounts/1/folders/SU5CT1g= and /accounts/1/folders/SU5CT1g=/message/1 and the nav item should be active for both routs, hence no exact matching.

Probably related to #25.
@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Sep 20, 2018
@skjnldsv
Copy link
Contributor

Do it ;)

ChristophWurst added a commit that referenced this issue Sep 25, 2018
@ChristophWurst
Make exact routing optional in AppNavigationItem
8696eaa 
Fixes #29

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst mentioned this issue Sep 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChristophWurst @skjnldsv