Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppNavigation needs individual sub components #25

Closed
skjnldsv opened this issue Sep 12, 2018 · 1 comment · Fixed by #195
Closed

AppNavigation needs individual sub components #25

skjnldsv opened this issue Sep 12, 2018 · 1 comment · Fixed by #195
Assignees
@ChristophWurst
Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-navigation Related to the app-navigation component high High priority
Milestone
0.6.0

Comments

@skjnldsv
Copy link
Contributor

Currently quite messy and will be a pain to add tests and props validation
@skjnldsv skjnldsv added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of feature: app-navigation Related to the app-navigation component high High priority labels Sep 12, 2018
@skjnldsv skjnldsv added this to the 0.2 milestone Sep 12, 2018
@ChristophWurst
Copy link
Contributor

I'd suggest to check out https://bootstrap-vue.js.org/docs/components/nav for inspiration 😉

@ChristophWurst ChristophWurst mentioned this issue Sep 20, 2018
Closed
@skjnldsv skjnldsv modified the milestones: 0.3.0, 0.2.1 Oct 15, 2018
@skjnldsv skjnldsv modified the milestones: 0.2.1, 0.3.2, 0.4.1, 0.4.2 Nov 6, 2018
@skjnldsv skjnldsv modified the milestones: 0.4.3, 0.4.4, 0.4.5 Nov 13, 2018
@skjnldsv skjnldsv modified the milestones: 0.4.5, 0.4.6, 0.4.7 Nov 26, 2018
@skjnldsv skjnldsv modified the milestones: 0.4.7, 0.5.1 Jan 8, 2019
@ChristophWurst ChristophWurst self-assigned this Jan 9, 2019
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 9, 2019
@ChristophWurst ChristophWurst modified the milestones: 0.5.1, 0.6.0 Jan 9, 2019
ChristophWurst added a commit that referenced this issue Jan 9, 2019
@ChristophWurst
Split AppNavigation into button, item and settings components
bf2e56e 
Fixes #25

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst mentioned this issue Jan 9, 2019
Merged
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 9, 2019
@skjnldsv skjnldsv mentioned this issue Jul 10, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement New feature or request feature: app-navigation Related to the app-navigation component high High priority
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Split AppNavigation into individual components nextcloud-libraries/nextcloud-vue
2 participants
@ChristophWurst @skjnldsv