Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split AppNavigation into individual components #195

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

ChristophWurst
Copy link
Contributor

Fixes #25.
Required for nextcloud/mail#1418 in order to add spacers to the navigation (will add the component here once implemented).

Again, this was extracted from Mail and thus follows https://docs.nextcloud.com/server/15/developer_manual/design/content.html.

New structure for apps using our default layout:

<AppContent app-name="mail">
	<template slot="navigation">
		<AppNavigationNew :text="t('mail', 'New message')"
						  buttonId="mail_new_message"
						  buttonClass="icon-add"
						  @click="onNewMessage"/>
		<ul id="accounts-list">
			<AppNavigationItem v-for="item in menu"
							   :key="item.key"
							   :item="item"/>
		</ul>
		<AppNavigationSettings :title="t('mail', 'Settings')">
			<AppSettingsMenu />
		</AppNavigationSettings>
	</template>
	<template slot="content">
		....
	</template>
	<template slot="sidebar">
		....
	</template>
</AppContent>

Breaking change, hence 0.6.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Fixes #25

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added enhancement New feature or request 3. to review Waiting for reviews labels Jan 9, 2019
@ChristophWurst ChristophWurst added this to the 0.6.0 milestone Jan 9, 2019
@ChristophWurst ChristophWurst self-assigned this Jan 9, 2019
@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3 PRs) in Christoph's Tasks via automation Jan 9, 2019
@ChristophWurst
Copy link
Contributor Author

Not particularly beautiful code, but you can see how I switched Mail to these new components: https://github.com/nextcloud/mail/pull/1456/files (a bit of duplication I yet have to clean up)

@ChristophWurst ChristophWurst added the component Component discussion and/or suggestion label Jan 9, 2019
@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3 PRs) to TO REVIEW (max 4 PRs) in Christoph's Tasks Jan 14, 2019
Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Jan 14, 2019
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2019
@ChristophWurst ChristophWurst merged commit 70a6ca6 into master Jan 15, 2019
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Jan 15, 2019
@ChristophWurst ChristophWurst deleted the enhancement/app-content-nav-content-sidebar branch January 15, 2019 08:08
@skjnldsv skjnldsv added the feature: app-navigation Related to the app-navigation component label Jun 11, 2019
@skjnldsv skjnldsv removed this from DONE in Christoph's Tasks Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish component Component discussion and/or suggestion enhancement New feature or request feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppNavigation needs individual sub components
2 participants