Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the common webpack configuration #2625

Closed
wants to merge 1 commit into from

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Apr 8, 2022

This migrates nextcloud/vue to the common nextcloud/webpack-vue-configuration. This simplifies the configuration drastically and also includes the legendary migration from node-sass to sass 馃槈

As a side note, the style guide only works properly when compiled in development mode, but it was like this before already.

Because we now use sass we see some Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. warnings, which will be fixed in a follow-up PR.

@raimund-schluessler raimund-schluessler marked this pull request as draft April 8, 2022 09:44
@raimund-schluessler raimund-schluessler force-pushed the fix/common-webpack-config branch 9 times, most recently from afdfb05 to 8b084ec Compare April 8, 2022 20:31
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Apr 8, 2022
@raimund-schluessler raimund-schluessler linked an issue Apr 8, 2022 that may be closed by this pull request
@raimund-schluessler raimund-schluessler marked this pull request as ready for review April 8, 2022 20:50
@raimund-schluessler raimund-schluessler mentioned this pull request Apr 8, 2022
20 tasks
@raimund-schluessler

This comment was marked as resolved.

@raimund-schluessler raimund-schluessler marked this pull request as draft April 9, 2022 05:27
@skjnldsv skjnldsv force-pushed the fix/common-webpack-config branch 2 times, most recently from 3d29e12 to 6674b69 Compare April 9, 2022 15:44
@skjnldsv skjnldsv marked this pull request as ready for review April 9, 2022 15:45
@raimund-schluessler
Copy link
Contributor Author

@skjnldsv There might be an issue with npm run styleguide again. The webpack-dev-server version required by @nextcloud/webpack-vue-config and vue-styleguidist seem to collide and I couldn't figure out how to solve it yet.

@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Apr 9, 2022
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Apr 9, 2022
@raimund-schluessler raimund-schluessler marked this pull request as draft April 9, 2022 18:10
@raimund-schluessler
Copy link
Contributor Author

@skjnldsv There might be an issue with npm run styleguide again. The webpack-dev-server version required by @nextcloud/webpack-vue-config and vue-styleguidist seem to collide and I couldn't figure out how to solve it yet.

Since this PR might be blocked for a while by this, I split the node-sass -> sass migration into a a separate PR: #2631.

@ASDFGamer
Copy link

I looked into this Issue for myself a bit, because I wanted to have vue 3 and if I see it correctly then vue-styleguidist uses a old Version of webpack-dev-server (3.11.3 instead of 4.7.2). And that Version can't be updated until react-styleguidist updates their version from 3.x to 4.x. They are working on that update with a lot of other changes for webpack 5 (styleguidist/react-styleguidist#1996).
This realy looks like it could take a while until the version is fixed.

Signed-off-by: Raimund Schl眉脽ler <raimund.schluessler@mailbox.org>
@susnux
Copy link
Contributor

susnux commented Nov 25, 2022

vue-styleguidist uses a old Version of webpack-dev-server (3.11.3 instead of 4.7.2). And that Version can't be updated until react-styleguidist updates their version from 3.x to 4.x.

This is done with version 12.0.0, but now vue-styleguidist needs to upgrade to webpack 5. Which seems like a bunch of work, so this might be blocked again for some time.

@skjnldsv
Copy link
Contributor

I think at this point we should move to vite and use the docgen-vite
https://vue-styleguidist.github.io/docgen-vite/
https://github.com/vue-styleguidist/vue-styleguidist/tree/dev/examples/docgen-vite/

@susnux
Copy link
Contributor

susnux commented Nov 25, 2022

I spend a quite some time porting it to webpack 5, but there is a bunch of dependencies pulling in old versions of webpack-dev-server, so that way looks a lot more promising :)

@raimund-schluessler
Copy link
Contributor Author

Fine with me. I close this issue then. In case vue-styleguidist moves to webpack5 before we move to vite, we can still revisit this PR.

@raimund-schluessler raimund-schluessler deleted the fix/common-webpack-config branch December 3, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @nextcloud/webpack-vue-config
4 participants