-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 #3692
Closed
Closed
Vue 3 #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6c9473
to
d704e38
Compare
5 tasks
Closed
20 tasks
2bc5375
to
39947fe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
db3456e
to
d8a1ac9
Compare
35f4479
to
82b9f08
Compare
33ab65f
to
8b0d807
Compare
This was referenced Feb 17, 2023
Merged
Merged
f8d8758
to
285d9fd
Compare
6d2a822
to
bc229ea
Compare
e0e34b5
to
807eaad
Compare
08ad995
to
058dffe
Compare
97e0cb4
to
c0a9ae9
Compare
39b62b4
to
487b8f8
Compare
c7e144d
to
456a379
Compare
4c08838
to
9a5336e
Compare
534c5fe
to
75cd61e
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
75cd61e
to
1d6df36
Compare
The components are now fully migrated, so this PR is not needed anymore. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
breaking
PR that requires a new major version
technical debt
vue 3
Related to the vue 3 migration
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at migrating all components to vue3.
Known issues:
NcRichText
does not work@nextcloud/vue-select
yetBreaking changes:
exact
prop ofNcAppNavigationItem
,NcBreadcrumb
,NcButton
andNcListItem
components is removed as vue-router 4 does not support it anymoreCompiling the Tasks apps vue3 branch from nextcloud/tasks#1971 together with this PR here already gives a fully working app. See here:
![Screenshot 2023-03-07 at 12-59-11 Aufgaben - Nextcloud](https://user-images.githubusercontent.com/2496460/223415974-76fcde27-4aa7-4c7e-bdc5-51668d30ffa1.png)