Adjust emits option #3773
Merged
Adjust emits option #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
ShGKme
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
It also helps with documentation and IDE. For example, the latest WebStorm EAP adds autocomplete for $emit: https://blog.jetbrains.com/webstorm/2023/02/webstorm-2023-1-eap-4/#completion_for_custom_component_events_in_vue
Should we add ESLint rule to catch it?
I don't know if it's worth adding the rule for vue2. It will come automatically with the vue3 migration. |
Documentation, IDE support. This PR adds missed |
Pytal
approved these changes
Feb 17, 2023
Pytal
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No effect for vue2, required for vue3. Makes the migration in #3692 a tiny bit shorter.