Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(NcRichContenteditable): add description block #4482

Closed
wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 29, 2023

☑️ Resolves

🖼️ Screenshots

image

image

🚧 Tasks

  • Discuss design
  • Update layout, add contenteditable container and description block
  • Proxy all attrs from the old root element to a new one
    • check if this is required
  • Add description prop with no default
  • Add #description slot with description prop as default value
  • Add show-DefaultDescription that enables showing classic Write message, use "@" to mention someone, use ":" for emoji autocompletion …
  • Change default placeholder from use "@" to blah-blah to Write a message
    • ? Or just remove default placeholder ?
  • Add tests

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added enhancement New feature or request accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: rich-contenteditable Related to the rich-contenteditable components labels Aug 29, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Aug 29, 2023
@ShGKme ShGKme self-assigned this Aug 29, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 29, 2023

@marcoambrosini what do you think about the design?

We could also do something like GitHub design with think dashed border, I think.

image

@marcoambrosini
Copy link
Contributor

@ShGKme I think that this is too complicated for the purpose of the sidebar. I also think labels are not a good way to deliver user documentation

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 7, 2023

Closed for not in flavor of nextcloud/server#40294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
2 participants