Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): move new comment instructions placeholder to description #40294

Merged
merged 2 commits into from Oct 7, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Sep 6, 2023

Summary

Adding an additional description slot to rich content editable could be not very suitable in a general case. An alternative is to add a description only here and just make the default placeholder short.

Screenshots

Before After
image image
image image
image image
image image

TODO

Checklist

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could be shortened more by cutting the "Use" at the sentence start, but fine like this too.

@ShGKme ShGKme force-pushed the fix/37087/new-comment-description branch from 0a7ed28 to 32bc99a Compare September 6, 2023 14:06
@ShGKme ShGKme changed the title [WIP] fix(comments): move instructions placeholder to description in new comment fix(comments): move new comment instructions placeholder to description Sep 6, 2023
@ShGKme ShGKme requested review from artonge and Pytal September 6, 2023 14:23
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's move on with this.

@ShGKme Is there something still to be done? All boxes/todos are checked.

@ShGKme
Copy link
Contributor Author

ShGKme commented Sep 20, 2023

@ShGKme Is there something still to be done? All boxes/todos are checked.

Upgrading to beta 6 and removing minor things that are in nextcloud/vue upstream (#40451)

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/37087/new-comment-description branch from 32bc99a to 0ce5a34 Compare October 7, 2023 06:46
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 7, 2023

Rebased onto master with new @nextcloud/vue, removed previously marked code that copied styles from new @nextcloud/vue. No visual or noticeable changes.

@ShGKme ShGKme added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 7, 2023
@ShGKme ShGKme marked this pull request as ready for review October 7, 2023 06:48
@ShGKme ShGKme enabled auto-merge October 7, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug feature: comments
Projects
None yet
5 participants