New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comments): move new comment instructions placeholder to description #40294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could be shortened more by cutting the "Use" at the sentence start, but fine like this too.
0a7ed28
to
32bc99a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let's move on with this.
@ShGKme Is there something still to be done? All boxes/todos are checked.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
32bc99a
to
0ce5a34
Compare
Rebased onto master with new |
Summary
Adding an additional description slot to rich content editable could be not very suitable in a general case. An alternative is to add a description only here and just make the default placeholder short.
Screenshots
TODO
centered
id
for safetyChecklist