Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing trailing comma #4654

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

raimund-schluessler
Copy link
Contributor

☑️ Resolves

Fixes a missing trailing comma. Honestly, I am not really convinced there should be a comma, but it makes eslint happy 🤷‍♂️

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Oct 15, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone Oct 15, 2023
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If eslint is happy, I'm happy too

@raimund-schluessler raimund-schluessler merged commit b69cce8 into master Oct 16, 2023
15 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/noid/rich-comma branch October 16, 2023 08:16
@ShGKme
Copy link
Contributor

ShGKme commented Oct 16, 2023

I am not really convinced there should be a comma, but it makes eslint happy 🤷‍♂️

There should, because it is the end of one object property value, so adding a new property would require modifying the first property by adding a comma

@Pytal Pytal mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants