Use logical style for NcHeaderMenu #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
force-pushed
the
use-logical-style-for-header-menu
branch
from
cca1d1f
to
41a0023
Compare
ShGKme
approved these changes
Dec 15, 2023
raimund-schluessler
approved these changes
Dec 15, 2023
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
ahangarha
force-pushed
the
use-logical-style-for-header-menu
branch
from
e0ce16f
to
9d122d0
Compare
susnux
approved these changes
Dec 15, 2023
|
We should do so for all components |
Pytal
approved these changes
Dec 15, 2023
|
@susnux We are good to go with other fixes as soon as we finish the PR for NextCloud Server. I am happy to have a small share in the development and improvement of this project. I hope we can finish this all very soon. |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The current styles used in NcHeaderMenu makes it hard to make NextCloud work fine in RTL mode automatically. In order to be able to add bidirectional text support to NextCloud (server), we need to use logical styles here, so the if the layout of the dashboard is RTL, the menu automatically moved to the right.
These changes shouldn't have any visible impact in the current state of NextCloud server. To test the impact, manually set the body to use
dir="RTL".There will be another PR on NextCloud server. It will depend on this PR to get merged. It will be linked to this PR as soon as it is opened.
🖼️ Screenshots
🚧 Tasks
Nothing remained
🏁 Checklist