Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcCounterBubble): increase size #5985

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix(NcCounterBubble): increase size #5985

merged 1 commit into from
Aug 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 19, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design labels Aug 19, 2024
@ShGKme ShGKme added this to the 8.16.1 milestone Aug 19, 2024
@ShGKme ShGKme self-assigned this Aug 19, 2024
jancborchardt
jancborchardt approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so nice now!

@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@ShGKme
fix(NcCounterBubble): increase size
acb7cbf 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 20, 2024

Rebased onto master

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 20, 2024

Checked on stable28

@ShGKme ShGKme enabled auto-merge August 20, 2024 16:26
@ShGKme ShGKme merged commit 3a504fa into master Aug 20, 2024
19 checks passed
@ShGKme ShGKme deleted the fix/nc-counter-bubble-size branch August 20, 2024 16:27
@ShGKme ShGKme mentioned this pull request Aug 20, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 20, 2024
Merged
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 20, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Aug 20, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Milestone
8.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ShGKme @jancborchardt @marcoambrosini @DorraJaouad @Antreesy @susnux