perf(npm): only install cypress when needed #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run `npm ci` in a number of places and usually we do not need cypress to be installed. In text a sample run of `npm ci` without cypress took 26 sec. instead of 46 sec. This also prevents run failures due to network issues connecting to cypress. Documentation for the environment variable used: https://docs.cypress.io/guides/references/advanced-installation#Skipping-installation Signed-off-by: Max <max@nextcloud.com>
2 tasks
juliushaertl
approved these changes
Aug 30, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
npm ciin a number of placesand usually we do not need cypress to be installed.
In text a sample run of
npm ciwithout cypress took 24 sec. instead of 43 sec.This also prevents run failures due to network issues connecting to cypress.
Documentation for the environment variable used:
https://docs.cypress.io/guides/references/advanced-installation#Skipping-installation