Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: skip cypress install #40589

Merged
merged 1 commit into from Sep 23, 2023
Merged

ci: skip cypress install #40589

merged 1 commit into from Sep 23, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Sep 22, 2023

Summary

Unnecessary to download the cypress binary if we don't run cypress

Workflow eslint:

image

Workflow cypress:

image

TODO

  • Does it work?
  • CI

Checklist

@kesselb kesselb added 2. developing Work in progress tests Related to tests labels Sep 22, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Sep 22, 2023
@kesselb kesselb self-assigned this Sep 22, 2023
@kesselb kesselb force-pushed the ci/noid/skip-cypress-download branch 2 times, most recently from b490c21 to b16e059 Compare September 22, 2023 15:14
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 22, 2023
Unecessary to download the cypress binary if we don't run cypress

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the ci/noid/skip-cypress-download branch from b16e059 to beb0b34 Compare September 22, 2023 15:42
@kesselb
Copy link
Contributor Author

kesselb commented Sep 22, 2023

Ref: nextcloud/.github#220

Updated the pull request to use the workflow-templates from nextcloud/.github when applicable.

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for taking care of this!

@skjnldsv skjnldsv merged commit b6f13cb into master Sep 23, 2023
41 of 42 checks passed
@skjnldsv skjnldsv deleted the ci/noid/skip-cypress-download branch September 23, 2023 09:46
@kesselb kesselb mentioned this pull request Sep 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants