Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable15] Try to support 7.3 for DAV #213

Merged
merged 1 commit into from Feb 19, 2019
Merged

[stable15] Try to support 7.3 for DAV #213

merged 1 commit into from Feb 19, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #186

@nickvergessen
Try to support 7.3 for DAV
34e81bd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2019
Merged
@J0WI J0WI modified the milestone: Nextcloud 15.0.3 Jan 16, 2019
@J0WI
Copy link

J0WI commented Jan 16, 2019

We just switched to PHP 7.3 for NC 15 in nextcloud/docker#573, so would be great to have this fix in the next 15 release.

@J0WI J0WI mentioned this pull request Jan 16, 2019
Closed
@stweil
Copy link
Member

stweil commented Feb 18, 2019

One of the CI tests fails (https://drone.nextcloud.com/nextcloud/3rdparty/315/3), but that seems to be related to the PHP version, not to this pull request.

So can it be merged? NC 15 needs it.

@stweil
Copy link
Member

stweil commented Feb 18, 2019

I close and re-open this PR to trigger a new CI run.

@stweil stweil closed this Feb 18, 2019
@stweil stweil reopened this Feb 18, 2019
@stweil stweil closed this Feb 18, 2019
@stweil stweil reopened this Feb 18, 2019
@stweil
Copy link
Member

stweil commented Feb 18, 2019

I close and re-open this PR to trigger a new CI run.

That trick obviously no longer works.

@MorrisJobke
Copy link
Member

That trick obviously no longer works.

It also wouldn't have solved the issue, because this runs master code on PHP 7.0, which is not possible anymore, because master only runs on PHP 7.1.

@MorrisJobke
Copy link
Member

But code makes sense and the CI is fixed in another PR -> let's merge this. Will run multiple times on CI soon anyways.

@MorrisJobke MorrisJobke merged commit 88f5727 into stable15 Feb 19, 2019
@MorrisJobke MorrisJobke deleted the backport/186/stable15 branch February 19, 2019 08:58
@MorrisJobke MorrisJobke added this to the Nextcloud 15.0.5 milestone Feb 19, 2019
@MorrisJobke MorrisJobke mentioned this pull request Feb 20, 2019
Merged
4 tasks
@J0WI J0WI mentioned this pull request Apr 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@kesselb kesselb kesselb approved these changes

@stweil stweil stweil approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 15.0.5
5 participants
@J0WI @stweil @MorrisJobke @nickvergessen @kesselb