-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable15] Try to support 7.3 for DAV #213
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
We just switched to PHP 7.3 for NC 15 in nextcloud/docker#573, so would be great to have this fix in the next 15 release. |
One of the CI tests fails (https://drone.nextcloud.com/nextcloud/3rdparty/315/3), but that seems to be related to the PHP version, not to this pull request. So can it be merged? NC 15 needs it. |
I close and re-open this PR to trigger a new CI run. |
That trick obviously no longer works. |
It also wouldn't have solved the issue, because this runs master code on PHP 7.0, which is not possible anymore, because master only runs on PHP 7.1. |
But code makes sense and the CI is fixed in another PR -> let's merge this. Will run multiple times on CI soon anyways. |
backport of #186