Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Try to support 7.3 for DAV #213

Merged
merged 1 commit into from Feb 19, 2019
Merged

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 14, 2019

backport of #186

Signed-off-by: Joas Schilling <coding@schilljs.com>
@J0WI J0WI modified the milestone: Nextcloud 15.0.3 Jan 16, 2019
@J0WI
Copy link

@J0WI J0WI commented Jan 16, 2019

We just switched to PHP 7.3 for NC 15 in nextcloud/docker#573, so would be great to have this fix in the next 15 release.

@stweil
Copy link
Member

@stweil stweil commented Feb 18, 2019

One of the CI tests fails (https://drone.nextcloud.com/nextcloud/3rdparty/315/3), but that seems to be related to the PHP version, not to this pull request.

So can it be merged? NC 15 needs it.

@stweil
stweil approved these changes Feb 18, 2019
@stweil
Copy link
Member

@stweil stweil commented Feb 18, 2019

I close and re-open this PR to trigger a new CI run.

@stweil stweil closed this Feb 18, 2019
@stweil stweil reopened this Feb 18, 2019
@stweil stweil closed this Feb 18, 2019
@stweil stweil reopened this Feb 18, 2019
@stweil
Copy link
Member

@stweil stweil commented Feb 18, 2019

I close and re-open this PR to trigger a new CI run.

That trick obviously no longer works.

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Feb 19, 2019

That trick obviously no longer works.

It also wouldn't have solved the issue, because this runs master code on PHP 7.0, which is not possible anymore, because master only runs on PHP 7.1.

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Feb 19, 2019

But code makes sense and the CI is fixed in another PR -> let's merge this. Will run multiple times on CI soon anyways.

@MorrisJobke MorrisJobke merged commit 88f5727 into stable15 Feb 19, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@MorrisJobke MorrisJobke deleted the backport/186/stable15 branch Feb 19, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 15.0.5 milestone Feb 19, 2019
@MorrisJobke MorrisJobke mentioned this pull request Feb 20, 2019
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants