Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add stub for files event to fix psalm error #1394

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: Add stub for files event to fix psalm error #1394

merged 2 commits into from
Nov 6, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 5, 2023

Fixing:

ERROR: InvalidArgument - lib/AppInfo/Application.php:139:13 - Incompatible types found for T (OCA\Files\Event\LoadSidebar|OCP\EventDispatcher\Event is not in OCP\EventDispatcher\Event) (see https://psalm.dev/004)
                $context->registerEventListener(LoadSidebar::class, LoadSidebarScripts::class);

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Nov 6, 2023

Cypress unrelated, seems to be broken on master branch.
So guess it can be merged by someone with permissions :)

@nickvergessen nickvergessen removed their request for review November 6, 2023 13:22
@miaulalala
Copy link
Collaborator

I can't. @artonge can you?

@artonge
Copy link
Collaborator

artonge commented Nov 6, 2023

No

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Nov 6, 2023

In this case I try to fix Cypress as well

@susnux susnux merged commit f3a96d8 into master Nov 6, 2023
34 checks passed
@susnux susnux deleted the fix/psalm branch November 6, 2023 18:51
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants