Add a clarifying comment to nginx.conf of reverse-proxy.md #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdomain and certbot Signed-off-by: Anton Podlozny <47890723+apodl1@users.noreply.github.com>
szaimen
added
3. to review
|
should maybe be also added to apache for example |
szaimen
reviewed
Mar 4, 2024
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example nginx.conf, if the user is running nextcloud on a subdomain of an already ssl secured domain, the -placeholders should be replaced with eg. "sub.example.com" in server_name and just "example.com" in ssl-cert related lines. I added a comment clarifying this into the provided .conf