fix(helm): image repo transformation yielding invalid yaml string syntax

[st3iny]

Did not test the update script! Please verify syntax etc.!

Helm fails to install the release: Error: YAML parse error on [...]: error converting YAML to JSON: yaml: line 42: did not find expected key

Broken

image: "{{ .Values.IMAGE_MIRROR_PREFIX }}{{ .Values.NEXTCLOUD_IMAGE_ORG }}"/foo-bar:baz

Working

image: "{{ .Values.IMAGE_MIRROR_PREFIX }}{{ .Values.NEXTCLOUD_IMAGE_ORG }}/foo-bar:baz"

[szaimen]

@st3iny do you know if there is some helm linting workflow available somewhere?

[szaimen]

Thanks!

[st3iny]

You could run helm lint 😄

$ helm lint
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/nextcloud-enterprise-database-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 66: did not find expected key
[ERROR] templates/nextcloud-enterprise-imaginary-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 31: did not find expected key
[ERROR] templates/nextcloud-enterprise-notify-push-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 54: did not find expected key
[ERROR] templates/nextcloud-enterprise-redis-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 43: did not find expected key

Error: 1 chart(s) linted, 1 chart(s) failed

[szaimen]

You could run helm lint 😄

$ helm lint
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/nextcloud-enterprise-database-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 66: did not find expected key
[ERROR] templates/nextcloud-enterprise-imaginary-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 31: did not find expected key
[ERROR] templates/nextcloud-enterprise-notify-push-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 54: did not find expected key
[ERROR] templates/nextcloud-enterprise-redis-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 43: did not find expected key

Error: 1 chart(s) linted, 1 chart(s) failed

okay you mean during the helm publish workflow?

[st3iny]

You could run helm lint 😄

$ helm lint
==> Linting .
[INFO] Chart.yaml: icon is recommended
[ERROR] templates/nextcloud-enterprise-database-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 66: did not find expected key
[ERROR] templates/nextcloud-enterprise-imaginary-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 31: did not find expected key
[ERROR] templates/nextcloud-enterprise-notify-push-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 54: did not find expected key
[ERROR] templates/nextcloud-enterprise-redis-deployment.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 43: did not find expected key

Error: 1 chart(s) linted, 1 chart(s) failed

okay you mean during the helm publish workflow?

I could also imagine a separate workflow lint-helm.yaml that is required for merges. Could even be made conditional (only on changes in nextcloud-enterprise-helm-chart/**) to save some CI time.

[st3iny]

We actually have such a workflow but it doesn't seem to run anymore. I'll investigate.

[st3iny]

It was disabled manually it seems.

[szaimen]

Lets for now add it to the helm release workflow: #4450