Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

run helm lint to catch any problems #4450

Merged
merged 1 commit into from
Mar 26, 2024
Merged

run helm lint to catch any problems #4450

merged 1 commit into from
Mar 26, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Mar 26, 2024

No description provided.

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Mar 26, 2024
@szaimen szaimen added this to the next milestone Mar 26, 2024
@szaimen szaimen requested a review from st3iny March 26, 2024 13:07
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue to fix the existing lint-helm workflow to catch problems early. Now, we'll only notice problems if a release is imminent instead of every time the updater runs.

We could just replace the (disabled) ct logic there with a single action helm lint nextcloud-aio-helm-chart for the time being.

@st3iny
Copy link
Member

st3iny commented Mar 26, 2024

E.g. something like #4451

@szaimen
Copy link
Collaborator Author

szaimen commented Mar 26, 2024

I'd argue to fix the existing lint-helm workflow to catch problems early. Now, we'll only notice problems if a release is imminent instead of every time the updater runs.

We could just replace the (disabled) ct logic there with a single action helm lint nextcloud-aio-helm-chart for the time being.

lets try both then

@szaimen szaimen merged commit d181a8c into main Mar 26, 2024
2 checks passed
@szaimen szaimen deleted the enh/noid/run-helm-lint branch March 26, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants