Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icons to website/twitter on user info screen #781

Closed
AndyScherzinger opened this issue Mar 27, 2017 · 3 comments
Closed

add icons to website/twitter on user info screen #781

AndyScherzinger opened this issue Mar 27, 2017 · 3 comments
Labels
approved design enhancement low pr exists
Milestone
Nextcloud App 2.0.0

Comments

@AndyScherzinger
Copy link
Member

As described in #585 (comment) also

  • use icons for the entries: website and twitter
  • remove http:// and https:// from the shown URL
  • make sure the twitter handle starts with an @
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.5.0 milestone Mar 27, 2017
@AndyScherzinger AndyScherzinger mentioned this issue Mar 27, 2017
Merged
@jancborchardt
Copy link
Member

Cool! :)

@schiessle maybe on the server we should also make sure that the Twitter handle starts with an @ and also for the placeholder use @… to make sure people know which format we want it in.

AndyScherzinger added a commit that referenced this issue Mar 27, 2017
@AndyScherzinger
#781 add icons to website/twitter on user info screen, cleanup
9ffb4c6
@AndyScherzinger AndyScherzinger mentioned this issue Mar 27, 2017
Merged
@AndyScherzinger
Copy link
Member Author

PR has been opened for review: #782

mario added a commit that referenced this issue Mar 27, 2017
@mario
Merge pull request #782 from nextcloud/userInfoUiFixes
8b3bdd7 
add icons to website/twitter on user info screen, cleanup - #781
@mario
Copy link
Contributor

mario commented Mar 27, 2017

Closing, merged

@mario mario closed this as completed Mar 27, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved design enhancement low pr exists
Projects
None yet
Milestone
Nextcloud App 2.0.0
Development

No branches or pull requests
3 participants
@mario @jancborchardt @AndyScherzinger