Use material 3 style for SSO dialog

[AlvaroBrey]

Before	After

[codecov]

Codecov Report

Merging #11001 (d56026f) into master (fb52b3f) will increase coverage by 28.08%.
The diff coverage is 0.00%.

❗ Current head d56026f differs from pull request most recent head 6810540. Consider uploading reports for the commit 6810540 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #11001       +/-   ##
=============================================
+ Coverage      3.23%   31.32%   +28.08%     
- Complexity      420     3273     +2853     
=============================================
  Files           544      544               
  Lines         40997    41008       +11     
  Branches       5681     5681               
=============================================
+ Hits           1328    12847    +11519     
+ Misses        39588    26245    -13343     
- Partials         81     1916     +1835     

Impacted Files	Coverage Δ
...ndroid/ui/activity/SsoGrantPermissionActivity.java	1.17% <0.00%> (+1.17%)	⬆️
.../third_parties/daveKoeller/AlphanumComparator.java	86.90% <0.00%> (-1.20%)	⬇️
.../java/com/owncloud/android/datamodel/GalleryRow.kt	50.00% <0.00%> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java	0.36% <0.00%> (+0.36%)	⬆️
...owncloud/android/ui/activity/PassCodeActivity.java	0.51% <0.00%> (+0.51%)	⬆️
...cloud/android/ui/preview/PreviewImageActivity.java	0.55% <0.00%> (+0.55%)	⬆️
...owncloud/android/ui/activity/UserInfoActivity.java	0.58% <0.00%> (+0.58%)	⬆️
...oud/android/ui/activity/NotificationsActivity.java	0.59% <0.00%> (+0.59%)	⬆️
...wncloud/android/ui/preview/PreviewVideoActivity.kt	0.94% <0.00%> (+0.94%)	⬆️
...ui/fragment/contactsbackup/BackupListFragment.java	0.94% <0.00%> (+0.94%)	⬆️
... and 274 more

[AndyScherzinger]

@AlvaroBrey the buttons/background(?) need theming after .show()

[AlvaroBrey]

@AlvaroBrey the buttons/background(?) need theming after .show()

I'm not sure it makes sense; as this activity may be called asking for permission for an user that's not the currently active user.

[stefan-niedermann]

Regarding theming I'd recommend white / black text for thr buttons. The default Material You color is not used anywhere I am aware of...

[AndyScherzinger]

I'm not sure it makes sense; as this activity may be called asking for permission for an user that's not the currently active user.

True while I would argue to either go with @stefan-niedermann suggestions to go with a fall back of black/white or we could just use a color based on the xml-values? In any case any color other the material's default violet would be good I think.

[AlvaroBrey]

What about R.color.primary (passed through m3 utils)? This way it's not as boring as white but it's still on-brand.

Dark	Light

[AndyScherzinger]

What about R.color.primary (passed through m3 utils)? This way it's not as boring as white but it's still on-brand.

@AlvaroBrey perfect, let's go with that, also did you check on background theming with surface ? I think we do this in other places like:

viewThemeUtils.dialog.colorMaterialAlertDialogBackground(
                    binding.pollVoteEndPollButton.context,
                    dialogBuilder
                )

might be tricky though since this doesn't have a color pass-through variant

[AlvaroBrey]

did you check on background theming with surface

Done. The only difference is that the background for the dark variant is a little darker (I guess for better contrast with the buttons)

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	83	83
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	28	28
Correctness	45	45
Dodgy code	341	341
Internationalization	9	9
Multithreaded correctness	9	9
Performance	58	58
Security	28	28
Total	518	518

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11001.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/6599-IT-master-08-50