move / copy updated #178
Merged
move / copy updated #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jancborchardt please help me on the wording of the second screenshot :) |
| @@ -137,7 +137,7 @@ public static void setSortAscending(Context context, boolean ascending) { | |||
| */ | |||
| public static int getUploaderBehaviour(Context context) { | |||
| return getDefaultSharedPreferences(context) | |||
| .getInt(AUTO_PREF__UPLOADER_BEHAVIOR, FileUploader.LOCAL_BEHAVIOUR_COPY); | |||
| .getInt(AUTO_PREF__UPLOADER_BEHAVIOR, 0); | |||
There was a problem hiding this comment.
Why did you remove the constant and replaced it with a "0" (which is the same as FileUploader.LOCAL_BEHAVIOUR_COPY)? I would have guess default is LOCAL_BEHAVIOUR_FORGET
|
Just some very minor things, code-wise 👍 |
AndyScherzinger
force-pushed
the
updateCopyMove
branch
3 times, most recently
from
e7d190a
to
9c25701
Compare
AndyScherzinger
force-pushed
the
updateCopyMove
branch
2 times, most recently
from
29c66c6
to
2394904
Compare
AndyScherzinger
force-pushed
the
updateCopyMove
branch
3 times, most recently
from
27093f3
to
8043ce3
Compare
AndyScherzinger
force-pushed
the
updateCopyMove
branch
from
8043ce3
to
76ddafa
Compare
AndyScherzinger
force-pushed
the
updateCopyMove
branch
from
07d00ba
to
3bea513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #26